Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1692813002: Revert of [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (patchset #4 id:60001 of https://codereview.chromium.org/1679133002/ ) Reason for revert: Breaks http/tests/inspector-enabled/dedicated-workers-list.html. BUG=586342 Original issue's description: > [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. > > In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy and make it responsible for "pause on start" decisions. > > BUG=none TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/3b7ee6da017512af80b20d6606255400ce5b3419 Cr-Commit-Position: refs/heads/master@{#375070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -72 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 7 chunks +37 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScopeProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js View 3 chunks +50 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 3 chunks +21 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
dgozman
4 years, 10 months ago (2016-02-12 01:09:40 UTC) #1
Created Revert of [DevTools] Remove isRunRequired, replace autoConnectToWorkers
with setWaitForDebuggerOnStart.

Powered by Google App Engine
This is Rietveld 408576698