Issue 16928010: Make text context responsible for setting GrPaint on GrDrawState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16928010: Make text context responsible for setting GrPaint on GrDrawState. (Closed)

Created:
7 years, 6 months ago by bsalomon

Modified:
7 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make text context responsible for setting GrPaint on GrDrawState. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9588

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -23 lines)			Patch
M	include/gpu/GrContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	7 chunks	+13 lines, -19 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

Another CL pulled out from the larger GrDrawState effect refactor. https://codereview.chromium.org/16928010/diff/1/src/gpu/GrTextContext.cpp File src/gpu/GrTextContext.cpp (right): https://codereview.chromium.org/16928010/diff/1/src/gpu/GrTextContext.cpp#newcode30 ...

7 years, 6 months ago (2013-06-13 14:20:53 UTC) #1

robertphillips

lgtm https://codereview.chromium.org/16928010/diff/1/src/gpu/GrTextContext.cpp File src/gpu/GrTextContext.cpp (right): https://codereview.chromium.org/16928010/diff/1/src/gpu/GrTextContext.cpp#newcode208 src/gpu/GrTextContext.cpp:208: fMaxVertices = kMinRequestedVerts; overlength

7 years, 6 months ago (2013-06-13 16:26:08 UTC) #2

bsalomon

7 years, 6 months ago (2013-06-13 17:44:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9588 (presubmit successful).

Expand Messages | Collapse Messages