Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/media/canvas_capture_test.html

Issue 1692773002: Canvas Capture: chrome browsertest- added frame rate test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Excluding mac trybots for now. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/chrome_webrtc_canvas_capture_browsertest.cc ('K') | « chrome/test/data/media/bear-640x360.webm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/media/canvas_capture_test.html
diff --git a/chrome/test/data/media/canvas_capture_test.html b/chrome/test/data/media/canvas_capture_test.html
new file mode 100644
index 0000000000000000000000000000000000000000..bb2ac4cd857e242abcb0f1dae75864ee73d8aaa0
--- /dev/null
+++ b/chrome/test/data/media/canvas_capture_test.html
@@ -0,0 +1,143 @@
+<!DOCTYPE html>
mcasas 2016/03/04 22:30:33 This file should go into chrome/test/data/media/ht
cpaulin (no longer in chrome) 2016/03/10 22:21:25 I have the feeling chrome/test/data/webrtc is wher
+<html>
+<head>
+<title>Canvas Capture FPS Test</title>
+</head>
+<body>
+ <div> Canvas capture FPS test.</div>
+ <video id='local-video' muted='true' hidden loop autoplay>
+ <source src='bear-640x360.webm' type='video/webm'>
mcasas 2016/03/04 22:30:33 What's the problem with the other bear webms aroun
cpaulin (no longer in chrome) 2016/03/10 22:21:24 They don't work, I tried them on linux and mac. Wh
+ </video>
+ <br></br>
+ <label>Canvas</label>
+ <canvas id='canvas' width=640 height=360></canvas>
mcasas 2016/03/04 22:30:33 Large canvas, for a browsertests that is supposed
cpaulin (no longer in chrome) 2016/03/10 22:21:25 I will look for a smaller video. Done.
+ <br></br>
+ <label>Captured canvas stream</label>
+ <video id='captured-video' autoplay></video>
+<script>
+
+'use strict';
+
+var DEFAULT_FRAME_RATE = 10;
+var TOLERANCE_PERCENT = 15 / 100;
mcasas 2016/03/04 22:30:33 This is not a percentage, but a per_one in any ca
cpaulin (no longer in chrome) 2016/03/10 22:21:24 Done.
+
+// Define video event listener when window is loaded.
+window.onload = function() {
+ var video = document.getElementById('local-video');
+ var canvas = document.getElementById('canvas');
+ var context = canvas.getContext('2d');
+ video.addEventListener('play', function() {
+ draw(this, context, canvas.clientWidth, canvas.clientHeight);
+ }, false);
+ };
+
+// This function draws the video frame on the canvas.
+function draw(video, context, width, height) {
+ window.requestAnimationFrame(draw.bind(null, video, context, width,
+ height));
+ if (video.paused || video.ended) return false;
+ context.drawImage(video, 0, 0, width, height);
+}
+
+// Test class that measures the frame rate of a stream originated from
+// canvas capture.
+function CanvasFpsTest() {
+ this.theCanvasStream = null;
mcasas 2016/03/04 22:30:33 Inconsistent indenting: here you use 2 spaces wher
cpaulin (no longer in chrome) 2016/03/10 22:21:25 window.onload indent is a line break not a typical
+ this.decodedFrames = 0;
+ this.droppedFrames = 0;
+ this.decodedFPS = [];
+ this.droppedFPS = [];
+ this.startTime = {};
+ this.interval = {};
+ this.targetFPS = 0;
+}
+
+// This function starts the canvas capture of the local video stream.
+CanvasFpsTest.prototype.startCanvasCapture = function(frameRate) {
+ var test = this;
mcasas 2016/03/04 22:30:33 Why aliasing? In l. 100+ you use |this|. Const?
cpaulin (no longer in chrome) 2016/03/10 22:21:25 Reason is this would not work: testVideo.addEventL
+ test.targetFPS = frameRate ? frameRate : DEFAULT_FRAME_RATE;
mcasas 2016/03/04 22:30:33 This function is only called by testFrameRateOfCan
cpaulin (no longer in chrome) 2016/03/10 22:21:24 I could remove the argument, it is not used in thi
+ test.theCanvasStream = document.getElementById('canvas').captureStream(
+ test.targetFPS);
+ var testVideo = document.getElementById('captured-video');
+ testVideo.addEventListener('play', function(event) {
+ test.startTime = new Date().getTime();
+ test.interval = setInterval(test.calculateStats.bind(test, testVideo),
+ 1000);
+ });
+ testVideo.src = URL.createObjectURL(test.theCanvasStream);
+};
+
+// This function calculates the FPS for decoded frames and dropped frames.
+CanvasFpsTest.prototype.calculateStats = function(video) {
+ // We calculate stats on 6 seconds worth of video, that should be
+ // reasonable.
+ if (this.decodedFPS.length == 6) {
mcasas 2016/03/04 22:30:33 Make a const out of this, put it on top of file?
cpaulin (no longer in chrome) 2016/03/10 22:21:25 Done.
+ clearInterval(this.interval);
+ return this.validateResults();
+ }
+ if (video.readyState <= HTMLMediaElement.HAVE_CURRENT_DATA ||
+ video.paused || video.ended)
+ return;
mcasas 2016/03/04 22:30:33 Uncertain about this but: {} around? (due to multi
cpaulin (no longer in chrome) 2016/03/10 22:21:24 Done.
+ var currentTime = new Date().getTime();
+ var deltaTime = (currentTime - this.startTime) / 1000;
+
+ this.startTime = currentTime;
+
+ // Calculate decoded frames per second.
+ var fps = (video.webkitDecodedFrameCount - this.decodedFrames) / deltaTime;
+ this.decodedFrames = video.webkitDecodedFrameCount;
+ this.decodedFPS.push(fps);
+
+ // Calculate dropped frames per second.
+ fps = (video.webkitDroppedFrameCount - this.droppedFrames) / deltaTime;
+ this.droppedFrames = video.webkitDroppedFrameCount;
+ this.droppedFPS.push(fps);
+};
+
+// This function validates the frame rate against accepted error tolerance.
+CanvasFpsTest.prototype.validateResults = function() {
+ // Pop out the first value as it could be a bit off.
+ this.decodedFPS.shift;
+ this.droppedFPS.shift;
+ var averageFPS = average(this.decodedFPS);
+ var averageDroppedFPS = average(this.droppedFPS);
+ var errorFPS = Math.abs(averageFPS - this.targetFPS) / this.targetFPS;
+ var minFPS = this.targetFPS * (1 - TOLERANCE_PERCENT);
+ var maxFPS = this.targetFPS * (1 + TOLERANCE_PERCENT);
+ console.log('Average dropped FPS:', averageDroppedFPS);
+ if (errorFPS > TOLERANCE_PERCENT) {
+ reportResult('ERROR: Expected FPS between ' + minFPS + ' and ' + maxFPS +
+ ' (' + 100 * TOLERANCE_PERCENT + '% tolerance) but got ' + averageFPS +
+ ' instead');
+ } else {
+ reportResult('OK');
+ }
+};
+
+// This function calculates average of array values.
+function average(array) {
+ var count = array.length;
+ var total = 0;
+ for (var i = 0; i < count; i++) {
mcasas 2016/03/04 22:30:33 for (value i in array) ... https://google.githu
cpaulin (no longer in chrome) 2016/03/10 22:21:25 Done.
+ total += parseInt(array[i]);
+ }
+ return Math.floor(total / count);
+}
+
+// This function logs and reports result to Test Environment.
+function reportResult(message) {
+ console.log(message);
+ if (!window.domAutomationController)
+ throw 'Expected to run in an automated context.';
+ window.domAutomationController.send(message);
+}
+
+// Tests that canvas capture will approximately honor the given frame rate.
+function testFrameRateOfCanvasCapture(frameRate) {
+ var fpsTest = new CanvasFpsTest();
+ fpsTest.startCanvasCapture(frameRate);
+}
+
+</script>
+</body>
+</html>
« chrome/browser/media/chrome_webrtc_canvas_capture_browsertest.cc ('K') | « chrome/test/data/media/bear-640x360.webm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698