Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1692723002:
Add Bluez initialize call to startup for app_shell. (Closed)
|
Created:
4 years, 10 months ago by drustsmith Modified:
4 years, 10 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, joth Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Bluez initialize call to startup.
Solution copied from similar fix in content shell:
https://crrev.com/1487183002 (fix for issue 552488)
in file: /content/shell/browser/shell_browser_main_parts.cc
BUG=585586
Committed: https://crrev.com/72be257ccfaca7dcd2f48db66b0c2191607b6bfc
Cr-Commit-Position: refs/heads/master@{#376863}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fix comments. #
Messages
Total messages: 25 (14 generated)
drustsmith@google.com changed reviewers: + jamescook@google.com
Hi James, This is my first change for chromium so please let me know if I've missed anything. Thanks, David
Description was changed from ========== Add Bluez initialize call to startup. I copied the solution implemented in the bug fix for issue 552488 in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ========== to ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ==========
Description was changed from ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ========== to ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ==========
jamescook@chromium.org changed reviewers: + jamescook@chromium.org
https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... File extensions/shell/browser/shell_browser_main_parts.cc (right): https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:21: #include "device/bluetooth/bluetooth_adapter_factory.h" Put this in the OS_CHROMEOS block below. https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:59: #include "device/bluetooth/dbus/bluez_dbus_manager.h" Put this in the OS_CHROMEOS block above. https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:121: bluez::BluezDBusManager::Initialize( It probably doesn't matter, but since the other CL does this initialization before NetworkHandler::Initialize(), please move this up above to match.
https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... File extensions/shell/browser/shell_browser_main_parts.cc (right): https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:21: #include "device/bluetooth/bluetooth_adapter_factory.h" On 2016/02/11 23:17:59, James Cook (inactive) wrote: > Put this in the OS_CHROMEOS block below. Done. https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:59: #include "device/bluetooth/dbus/bluez_dbus_manager.h" On 2016/02/11 23:17:59, James Cook (inactive) wrote: > Put this in the OS_CHROMEOS block above. Done. https://codereview.chromium.org/1692723002/diff/1/extensions/shell/browser/sh... extensions/shell/browser/shell_browser_main_parts.cc:121: bluez::BluezDBusManager::Initialize( On 2016/02/11 23:17:58, James Cook (inactive) wrote: > It probably doesn't matter, but since the other CL does this initialization > before NetworkHandler::Initialize(), please move this up above to match. Done.
LGTM
The CQ bit was checked by joth@chromium.org
The CQ bit was unchecked by joth@chromium.org
The CQ bit was checked by drustsmith@google.com
The CQ bit was unchecked by drustsmith@google.com
The CQ bit was checked by joth@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
joth@chromium.org changed reviewers: + armansito@chromium.org, scheib@chromium.org
+scheib (OOO) and +armansito (inactive) for OWNERS approval for new dep on device/bluetooth (This is a straight copy from chrome to app_shell so hopefully not controversial)
LGTM
The CQ bit was checked by joth@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692723002/20001
Message was sent while issue was closed.
Description was changed from ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ========== to ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 ========== to ========== Add Bluez initialize call to startup. Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 Committed: https://crrev.com/72be257ccfaca7dcd2f48db66b0c2191607b6bfc Cr-Commit-Position: refs/heads/master@{#376863} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/72be257ccfaca7dcd2f48db66b0c2191607b6bfc Cr-Commit-Position: refs/heads/master@{#376863} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
