Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: test/cctest/test-log-stack-tracer.cc

Issue 1692693004: [Interpreter] Fix test-log-stack-tracer for Ignition. (Closed) Base URL: ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 // This C++ function is called as a constructor, to grab the frame pointer 76 // This C++ function is called as a constructor, to grab the frame pointer
77 // from the calling function. When this function runs, the stack contains 77 // from the calling function. When this function runs, the stack contains
78 // a C_Entry frame and a Construct frame above the calling function's frame. 78 // a C_Entry frame and a Construct frame above the calling function's frame.
79 static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) { 79 static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) {
80 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate()); 80 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
81 i::StackFrameIterator frame_iterator(isolate); 81 i::StackFrameIterator frame_iterator(isolate);
82 CHECK(frame_iterator.frame()->is_exit()); 82 CHECK(frame_iterator.frame()->is_exit());
83 frame_iterator.Advance(); 83 frame_iterator.Advance();
84 CHECK(frame_iterator.frame()->is_construct()); 84 CHECK(frame_iterator.frame()->is_construct());
85 frame_iterator.Advance(); 85 frame_iterator.Advance();
86 if (i::FLAG_ignition) {
87 // Skip over bytecode handler frame.
88 CHECK(frame_iterator.frame()->type() == i::StackFrame::STUB);
89 frame_iterator.Advance();
90 }
86 i::StackFrame* calling_frame = frame_iterator.frame(); 91 i::StackFrame* calling_frame = frame_iterator.frame();
87 CHECK(calling_frame->is_java_script()); 92 CHECK(calling_frame->is_java_script());
88 93
89 v8::Local<v8::Context> context = args.GetIsolate()->GetCurrentContext(); 94 v8::Local<v8::Context> context = args.GetIsolate()->GetCurrentContext();
90 #if defined(V8_HOST_ARCH_32_BIT) 95 #if defined(V8_HOST_ARCH_32_BIT)
91 int32_t low_bits = reinterpret_cast<int32_t>(calling_frame->fp()); 96 int32_t low_bits = reinterpret_cast<int32_t>(calling_frame->fp());
92 args.This() 97 args.This()
93 ->Set(context, v8_str("low_bits"), v8_num(low_bits >> 1)) 98 ->Set(context, v8_str("low_bits"), v8_num(low_bits >> 1))
94 .FromJust(); 99 .FromJust();
95 #elif defined(V8_HOST_ARCH_64_BIT) 100 #elif defined(V8_HOST_ARCH_64_BIT)
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION); 289 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION);
285 v8::Context::Scope context_scope(context); 290 v8::Context::Scope context_scope(context);
286 CHECK(!i::TraceExtension::GetJsEntrySp()); 291 CHECK(!i::TraceExtension::GetJsEntrySp());
287 CompileRun("a = 1; b = a + 1;"); 292 CompileRun("a = 1; b = a + 1;");
288 CHECK(!i::TraceExtension::GetJsEntrySp()); 293 CHECK(!i::TraceExtension::GetJsEntrySp());
289 CompileRun("js_entry_sp();"); 294 CompileRun("js_entry_sp();");
290 CHECK(!i::TraceExtension::GetJsEntrySp()); 295 CHECK(!i::TraceExtension::GetJsEntrySp());
291 CompileRun("js_entry_sp_level2();"); 296 CompileRun("js_entry_sp_level2();");
292 CHECK(!i::TraceExtension::GetJsEntrySp()); 297 CHECK(!i::TraceExtension::GetJsEntrySp());
293 } 298 }
OLDNEW
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698