Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1692693004: [Interpreter] Fix test-log-stack-tracer for Ignition. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
ssh://rmcilroy.lon.corp.google.com///usr/local/google/code/v8_full/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix test-log-stack-tracer for Ignition. BUG=v8:4680 LOG=N Committed: https://crrev.com/7a5b2339e7f9d7ff87c43aa8fb74530e386a1067 Cr-Commit-Position: refs/heads/master@{#33930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692693004/1
4 years, 10 months ago (2016-02-11 21:18:06 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 21:40:21 UTC) #4
rmcilroy
Ptal, thanks.
4 years, 10 months ago (2016-02-12 08:42:34 UTC) #6
Yang
On 2016/02/12 08:42:34, rmcilroy wrote: > Ptal, thanks. lgtm.
4 years, 10 months ago (2016-02-12 08:44:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692693004/1
4 years, 10 months ago (2016-02-12 08:47:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 08:48:51 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 08:49:25 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7a5b2339e7f9d7ff87c43aa8fb74530e386a1067
Cr-Commit-Position: refs/heads/master@{#33930}

Powered by Google App Engine
This is Rietveld 408576698