chrome/browser/about_flags.cc - Issue 1692693003: add a flag to enable/disable download interception on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1692693003: add a flag to enable/disable download interception on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/intercept_download_resource_throttle.h » ('j') | chrome/browser/android/intercept_download_resource_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 03a8170504b43c935fb2b0b35d9634ed3506995c..76959f2cc65efbd41adb2da64049e8245b04715e 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -853,6 +853,14 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAGS_DOWNLOAD_RESUMPTION_DESCRIPTION,

kOsAll,

FEATURE_VALUE_TYPE(features::kDownloadResumption)},

+#if defined(OS_ANDROID)

+ {"download-interception",

+ IDS_FLAGS_DOWNLOAD_INTERCEPTION_NAME,

+ IDS_FLAGS_DOWNLOAD_INTERCEPTION_DESCRIPTION,

+ kOsAndroid,

+ ENABLE_DISABLE_VALUE_TYPE(switches::kEnableDownloadInterception,

+ switches::kDisableDownloadInterception)},

+#endif

#if defined(OS_CHROMEOS)

{"download-notification",

IDS_FLAGS_DOWNLOAD_NOTIFICATION_NAME,