Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 1692693003: add a flag to enable/disable download interception on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: allow server trial to be overriden Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index 0f8a31b584d86bd7990de5e7977ffe6e44236d9b..40c2e26ccd64139a296d5c66c367f55a3ad2a98e 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -418,9 +418,11 @@ void ChromeResourceDispatcherHostDelegate::DownloadStarting(
download_request_limiter_, info->GetWebContentsGetterForRequest(),
request->url(), request->method()));
#if BUILDFLAG(ANDROID_JAVA_UI)
- throttles->push_back(
- new chrome::InterceptDownloadResourceThrottle(
- request, child_id, route_id, request_id));
+ if (chrome::InterceptDownloadResourceThrottle::
svaldez 2016/02/12 15:21:19 Consider getting rid of the check here, and instea
qinmin 2016/02/12 17:27:00 Done. However, there is a very tiny performance hi
+ IsDownloadInterceptionEnabled()) {
+ throttles->push_back(new chrome::InterceptDownloadResourceThrottle(
+ request, child_id, route_id, request_id));
+ }
#endif
}

Powered by Google App Engine
This is Rietveld 408576698