Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1692683003: Put back the 0.5 bias in the shader. Only adjust the radii for the geometry, not the radii constant… (Closed)

Created:
4 years, 10 months ago by Brian Osman
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Put back the 0.5 bias in the shader. Only adjust the radii for the geometry, not the radii constants. After working through this with Jim, this is more mathematically correct, and also accounts for the inner radius. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683003 Committed: https://skia.googlesource.com/skia/+/c6052ac41a704cc64f16c49780a8fd05c7f550d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Brian Osman
4 years, 10 months ago (2016-02-12 17:45:48 UTC) #4
jvanverth1
lgtm
4 years, 10 months ago (2016-02-12 17:49:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692683003/1
4 years, 10 months ago (2016-02-12 17:52:01 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 18:20:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c6052ac41a704cc64f16c49780a8fd05c7f550d4

Powered by Google App Engine
This is Rietveld 408576698