Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1692683002: fixed off-by-one error in skiaserve /cmd (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
jcgregorio, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 10 months ago (2016-02-11 20:44:38 UTC) #3
jcgregorio
lgtm
4 years, 10 months ago (2016-02-11 20:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692683002/1
4 years, 10 months ago (2016-02-11 20:48:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 21:10:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f8289d9bd1faff400728cb8e1ac0b1aa68bfbc32

Powered by Google App Engine
This is Rietveld 408576698