Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1692673004: Revert of Add support for 'href' (w/o XLink NS) for various SVG elements (Closed)

Created:
4 years, 10 months ago by carlosk
Modified:
4 years, 10 months ago
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, Eric Willigers, f(malita), gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for 'href' (w/o XLink NS) for various SVG elements (patchset #6 id:100001 of https://codereview.chromium.org/1681553002/ ) Reason for revert: This CL seems to be breaking the compilation step of a lot of Android bots. Reverting. Original issue's description: > Add support for 'href' (w/o XLink NS) for various SVG elements > > This CL adds a new wrapper type SVGAnimatedHref that wraps 'href' (the > new, null/default NS version) and '(xlink:)href' (the XLink NS version). > This wrapper type is used by SVGURIReference and thus most uses of > 'href' is covered by this part. SVGAnimatedHref is intended as a wrapper > for accessing the underlying value of either 'href' or 'xlink:href'. Any > updates due to setAttribute or will go directly to the underlying values > which means that synchronization etc. does not apply to the wrapper. > This is one of the "pro"s of this approach - it does not require any > modification to synching between the SVGString object and the attribute > in certain cases (like when the "active" attribute is removed). A "con" > would be that there's a lot of dead space in the object since the > wrapper itself still needs to implement the SVGAnimatedString interface > even if just forwards to the actual SVGString. > The UseCounter for href.baseVal/animVal are moved to the new wrapper. > > For cases where SVGURIReference is not used, new code-paths are added to > select the right attribute. > > Animation code is updated to target the 'href' in the null/default NS. > > BUG=584142 TBR=alancutter@chromium.org,davve@opera.com,pdr@chromium.org,fs@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -603 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/svg-animate-href.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/svg-animate-href-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/svg-script-tag-href.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/svg-script-tag-href-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/image-href.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/image-href-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns-precedence.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns-precedence-dynamic.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns-precedence-dynamic-expected.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/use-href-null-ns-precedence-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/href-semantics.html View 1 chunk +0 lines, -137 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 4 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/VisitedLinkState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/svg/SVGAnimatedHref.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/core/svg/SVGAnimatedHref.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 4 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.h View 4 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.cpp View 2 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp View 8 chunks +3 lines, -117 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
carlosk
Created Revert of Add support for 'href' (w/o XLink NS) for various SVG elements
4 years, 10 months ago (2016-02-12 16:47:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692673004/1
4 years, 10 months ago (2016-02-12 16:47:37 UTC) #2
carlosk
4 years, 10 months ago (2016-02-12 16:49:28 UTC) #5
My bad. This CL is probably not the culprit. Removed this revert from the CQ.

Powered by Google App Engine
This is Rietveld 408576698