Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 1692623006: PPAPI: Remove PPB_Font_Dev. (try 2) (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 8 months ago
Reviewers:
bbudge, Xing, binji
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, Sam Clegg, ihf+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Remove PPB_Font_Dev. (try 2) The first attempt in r357449 resulted in a partial revert in r357968. This reverts r357968, so effectively this lands all of r357449. BUG=551093 Committed: https://crrev.com/d095f27ed2490568eee0e051e6b4db7e8e715219 Cr-Commit-Position: refs/heads/master@{#383660}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Remove PPB_Font_Dev bits that snuck back in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -614 lines) Patch
M chrome/common/ppapi_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/verify_ppapi.py View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/api/dev/ppb_font_dev.idl View 1 chunk +0 lines, -261 lines 0 comments Download
D ppapi/c/dev/ppb_font_dev.h View 1 chunk +0 lines, -278 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 6 chunks +0 lines, -64 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Lei Zhang
4 years, 10 months ago (2016-02-19 02:20:58 UTC) #2
binji
native_client_sdk lgtm
4 years, 10 months ago (2016-02-19 03:18:28 UTC) #3
bbudge
lgtm
4 years, 10 months ago (2016-02-19 10:14:24 UTC) #4
Lei Zhang
Xing: Can you take a look?
4 years, 8 months ago (2016-03-28 19:22:24 UTC) #5
Xing
LGTM Flash player only relies on PPB_BrowserFont_Trusted interface, PPB_Font_Dev is not used. On 2016/03/28 19:22:24, ...
4 years, 8 months ago (2016-03-28 20:44:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692623006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692623006/20001
4 years, 8 months ago (2016-03-28 23:18:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/162995) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-28 23:29:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692623006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692623006/40001
4 years, 8 months ago (2016-03-29 00:33:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 02:46:22 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 02:47:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d095f27ed2490568eee0e051e6b4db7e8e715219
Cr-Commit-Position: refs/heads/master@{#383660}

Powered by Google App Engine
This is Rietveld 408576698