Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular

Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular

- rename sdk/lib/io/iolib_sources.gypi to sdk/lib/io/io_sources.gypi so that io is regular with respect to the other sdk libraries.
- Lint sdk/lib/*/*_sources.gypi
- Add dart_sdk_lib_copy gn template.

Related https://github.com/flutter/flutter/issues/1712

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c110887618cb5d80a23d999a74b8334562aedf0

[Cutch, 2016-02-11 18:43:14]

Description was changed from

==========
Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular
==========

to

==========
Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular

- rename sdk/lib/io/iolib_sources.gypi to sdk/lib/io/io_sources.gypi so that io
is regular with respect to the other sdk libraries.
- Lint sdk/lib/*/*_sources.gypi
- Add dart_sdk_lib_copy gn template.

Related https://github.com/flutter/flutter/issues/1712
==========

[Cutch, 2016-02-11 18:43:14]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[zra, 2016-02-11 18:58:37]

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode79
runtime/bin/BUILD.gn:79: iolib_sources_gypi =
Maybe sdk_io_sources_gypi instead

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode84
runtime/bin/BUILD.gn:84: iolib_sources = rebase_path(iolib_sources_gypi.sources,
".", "../../sdk/lib/io")
sdk_io_sources

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode89
runtime/bin/BUILD.gn:89: sources = ["../../sdk/lib/io/io.dart"] + iolib_sources
sdk_io_sources

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/developer/developer...
File sdk/lib/developer/developer_sources.gypi (right):

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer_sources.gypi:8: # The above file needs to be first
if additional parts are added to the lib.
Does this mean developer.dart? Maybe name it explicitly in the comment.

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/io/io_sources.gypi
File sdk/lib/io/io_sources.gypi (right):

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/io/io_sources.gypi#...
sdk/lib/io/io_sources.gypi:8: # The above file needs to be first if additional
parts are added to the lib.
ditto

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni
File sdk/lib/rules.gni (right):

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni#newcode17
sdk/lib/rules.gni:17: lib_path = rebase_path(lib_name, "", "//dart/sdk/lib/")
Can //dart be an argument instead of hardcoded?

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni#newcode22
sdk/lib/rules.gni:22: exec_script("//dart/tools/gypi_to_gn.py",
ditto

[Cutch, 2016-02-11 19:34:33]

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode79
runtime/bin/BUILD.gn:79: iolib_sources_gypi =
On 2016/02/11 18:58:37, zra wrote:
> Maybe sdk_io_sources_gypi instead

Done.

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode84
runtime/bin/BUILD.gn:84: iolib_sources = rebase_path(iolib_sources_gypi.sources,
".", "../../sdk/lib/io")
On 2016/02/11 18:58:37, zra wrote:
> sdk_io_sources

Done.

https://codereview.chromium.org/1692603002/diff/1/runtime/bin/BUILD.gn#newcode89
runtime/bin/BUILD.gn:89: sources = ["../../sdk/lib/io/io.dart"] + iolib_sources
On 2016/02/11 18:58:37, zra wrote:
> sdk_io_sources

Done.

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/developer/developer...
File sdk/lib/developer/developer_sources.gypi (right):

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer_sources.gypi:8: # The above file needs to be first
if additional parts are added to the lib.
On 2016/02/11 18:58:37, zra wrote:
> Does this mean developer.dart? Maybe name it explicitly in the comment.

This is a boiler plate comment that is in every single _sources.gypi file.

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni
File sdk/lib/rules.gni (right):

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni#newcode17
sdk/lib/rules.gni:17: lib_path = rebase_path(lib_name, "", "//dart/sdk/lib/")
On 2016/02/11 18:58:37, zra wrote:
> Can //dart be an argument instead of hardcoded?

Done.

https://codereview.chromium.org/1692603002/diff/1/sdk/lib/rules.gni#newcode22
sdk/lib/rules.gni:22: exec_script("//dart/tools/gypi_to_gn.py",
On 2016/02/11 18:58:37, zra wrote:
> ditto

Done.

[zra, 2016-02-11 20:31:05]

lgtm

[Cutch, 2016-02-11 22:23:25]

Description was changed from

==========
Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular

- rename sdk/lib/io/iolib_sources.gypi to sdk/lib/io/io_sources.gypi so that io
is regular with respect to the other sdk libraries.
- Lint sdk/lib/*/*_sources.gypi
- Add dart_sdk_lib_copy gn template.

Related https://github.com/flutter/flutter/issues/1712
==========

to

==========
Introduce dart_sdk_lib_copy and make all sdk lib gypi files regular

- rename sdk/lib/io/iolib_sources.gypi to sdk/lib/io/io_sources.gypi so that io
is regular with respect to the other sdk libraries.
- Lint sdk/lib/*/*_sources.gypi
- Add dart_sdk_lib_copy gn template.

Related https://github.com/flutter/flutter/issues/1712

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0c110887618cb5d80a23d999a74b8334562aedf0
==========

[Cutch, 2016-02-11 22:23:26]

Committed patchset #2 (id:20001) manually as
0c110887618cb5d80a23d999a74b8334562aedf0 (presubmit successful).