Chromium Code Reviews| Index: net/base/network_delegate.h |
| diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h |
| index 07371371054719555164ca380a1b1cd0c5fc53e8..27a9316949bf98e50da7830e8170b8b5c9a14393 100644 |
| --- a/net/base/network_delegate.h |
| +++ b/net/base/network_delegate.h |
| @@ -55,6 +55,15 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe { |
| }; |
| typedef base::Callback<void(AuthRequiredResponse)> AuthCallback; |
| + // URLBlacklistState indicates if the URL was defined in blacklist, |
|
Thiemo Nagel
2016/03/08 18:44:35
There's no need to repeat "URLBlacklistState".
|
| + // in whitelist or is not present in either lists as defined in |
| + // URLBlacklist and URLWhitelist policies. |
| + enum URLBlacklistState { |
|
Thiemo Nagel
2016/03/08 18:44:35
Why do you need a tri-state? Please explain in CL
|
| + URL_IN_WHITELIST, |
| + URL_IN_BLACKLIST, |
| + URL_NEUTRAL_STATE, |
| + }; |
| + |
| virtual ~NetworkDelegate() {} |
| // Notification interface called by the network stack. Note that these |
| @@ -119,6 +128,10 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe { |
| const GURL& target_url, |
| const GURL& referrer_url) const; |
| + // This function is to be used to check if the url is defined in |
|
Thiemo Nagel
2016/03/08 18:44:35
Use pipes to refer to a parameter, such as |url|.
|
| + // blacklist or whitelist policy. |
| + virtual URLBlacklistState GetURLBlacklistState(const GURL& url); |
|
Thiemo Nagel
2016/03/08 18:44:35
Please make the method const.
|
| + |
| private: |
| // This is the interface for subclasses of NetworkDelegate to implement. These |
| // member functions will be called by the respective public notification |