android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc - Issue 1692503002: Functionality to allow blacklist and whitelist of custom schemes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Issue 1692503002: Functionality to allow blacklist and whitelist of custom schemes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h ('k') | chrome/browser/net/chrome_network_delegate.h » ('j') | content/browser/loader/resource_dispatcher_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

diff --git a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

index 76befbcf51d64d4fc4ff6144259042ded34c0f48..7e9a3d6dda0426fe3de3ba5850f5881aca556c82 100644

--- a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

+++ b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

@@ -317,7 +317,8 @@ bool AwResourceDispatcherHostDelegate::HandleExternalProtocol(

const content::ResourceRequestInfo::WebContentsGetter& web_contents_getter,

bool is_main_frame,

ui::PageTransition page_transition,

- bool has_user_gesture) {

+ bool has_user_gesture,

+ bool is_whitelisted) {

// The AwURLRequestJobFactory implementation should ensure this method never

// gets called.

NOTREACHED();