Functionality to allow blacklist and whitelist of custom schemes

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <stddef.h>
 #include <algorithm>
@@ skipping 833 matching lines @@
   ResourceRequestInfoImpl* info = loader->GetRequestInfo();
 
   if (!IsResourceTypeFrame(info->GetResourceType()))
     return false;
 
   const net::URLRequestJobFactory* job_factory =
       info->GetContext()->GetRequestContext()->job_factory();
   if (job_factory->IsHandledURL(url))
     return false;
 
+  net::URLRequest* req = loader->request();

[Thiemo Nagel, 2016/03/08 18:44:35]

Can you make this const?

+  net::NetworkDelegate* network_delegate = req->network_delegate();

[Thiemo Nagel, 2016/03/08 18:44:35]

Can you make this const?

+  // get the state, if url is in blacklist, whitelist or in none of those.

[Thiemo Nagel, 2016/03/08 18:44:35]

Please start comment with capital letter.

+  net::NetworkDelegate::URLBlacklistState urlState =

[Thiemo Nagel, 2016/03/08 18:44:35]

const

+      network_delegate->GetURLBlacklistState(url);
+
+  if(urlState == net::NetworkDelegate::URLBlacklistState::URL_IN_BLACKLIST) {

[Thiemo Nagel, 2016/03/08 18:44:35]

Please add a blank between "if" and "(".

+    // It's a link with custom scheme and it's blacklisted.

[Thiemo Nagel, 2016/03/08 18:44:35]

Please wrap comment lines at 80 characters to save vertical space.

+    // We return false here and let it process as a normal URL.
+    // Eventually chrome_network_delegate will see it's in the blackist and

[Thiemo Nagel, 2016/03/08 18:44:35]

blackist --> blacklist

+    // the user will be shown the blocked content page.
+    return false;
+  }
+
   return delegate_->HandleExternalProtocol(
       url, info->GetChildID(), info->GetWebContentsGetterForRequest(),
-      info->IsMainFrame(), info->GetPageTransition(), info->HasUserGesture());
+      info->IsMainFrame(), info->GetPageTransition(), info->HasUserGesture(),
+      urlState == net::NetworkDelegate::URLBlacklistState::URL_IN_WHITELIST);
 }
 
 void ResourceDispatcherHostImpl::DidStartRequest(ResourceLoader* loader) {
   // Make sure we have the load state monitor running.
   if (!update_load_states_timer_->IsRunning() &&
       scheduler_->HasLoadingClients()) {
     update_load_states_timer_->Start(
         FROM_HERE, TimeDelta::FromMilliseconds(kUpdateLoadStatesIntervalMsec),
         this, &ResourceDispatcherHostImpl::UpdateLoadInfo);
   }
@@ skipping 1699 matching lines @@
     load_flags |= net::LOAD_PREFETCH;
   }
 
   if (is_sync_load)
     load_flags |= net::LOAD_IGNORE_LIMITS;
 
   return load_flags;
 }
 
 }  // namespace content