src/types.cc - Issue 16925008: Generate StoreGlobal stubs with Hydrogen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.cc

Issue 16925008: Generate StoreGlobal stubs with Hydrogen (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix test cases Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/types.cc

diff --git a/src/types.cc b/src/types.cc

index 03e12c44c04ba7ed5e8beae8b56b6622346e49cf..8a6f86f8b2f11442b954bdb69ad08bae3c6fe178 100644

--- a/src/types.cc

+++ b/src/types.cc

@@ -197,6 +197,12 @@ int Type::LubBitset() {

// We ought to find a cleaner solution for compiling stubs parameterised

// over type or class variables, esp ones with bounds...

return kDetectable;

+ case DECLARED_ACCESSOR_INFO_TYPE:

+ case EXECUTABLE_ACCESSOR_INFO_TYPE:

+ case ACCESSOR_PAIR_TYPE:

+ case JS_SET_TYPE:

rossberg 2013/06/25 10:47:38 JS_SET/MAP should actually go up to the other ordi

+ case JS_MAP_TYPE:

+ return kInternal;

default:

UNREACHABLE();

return kNone;