Index: src/stub-cache.cc |
diff --git a/src/stub-cache.cc b/src/stub-cache.cc |
index 1e0882f40082ad966ee440ed0afc4da5858e05d3..0ccd5e61b403a3946dc5ad4d4f157860526b6026 100644 |
--- a/src/stub-cache.cc |
+++ b/src/stub-cache.cc |
@@ -499,15 +499,30 @@ Handle<Code> StubCache::ComputeStoreNormal(StrictModeFlag strict_mode) { |
Handle<Code> StubCache::ComputeStoreGlobal(Handle<Name> name, |
Handle<GlobalObject> receiver, |
Handle<PropertyCell> cell, |
+ Handle<Object> value, |
StrictModeFlag strict_mode) { |
- Handle<Code> stub = FindIC( |
- name, Handle<JSObject>::cast(receiver), |
- Code::STORE_IC, Code::NORMAL, strict_mode); |
- if (!stub.is_null()) return stub; |
+ Isolate* isolate = cell->GetIsolate(); |
+ Handle<Type> union_type(PropertyCell::UpdateType(cell, value), isolate); |
+ bool is_constant = union_type->IsConstant(); |
+ StoreGlobalStub stub(strict_mode, is_constant); |
- StoreStubCompiler compiler(isolate_, strict_mode); |
- Handle<Code> code = compiler.CompileStoreGlobal(receiver, cell, name); |
+ Handle<Code> code = FindIC( |
+ name, Handle<JSObject>::cast(receiver), |
+ Code::STORE_IC, Code::NORMAL, stub.GetExtraICState()); |
+ if (!code.is_null()) return code; |
+ |
+ if (is_constant) return stub.GetCode(isolate_); |
+ |
+ // Replace the placeholder cell and global object map with the actual global |
+ // cell and receiver map. |
+ Handle<Map> cell_map(isolate_->heap()->global_property_cell_map()); |
+ Handle<Map> meta_map(isolate_->heap()->meta_map()); |
+ Handle<Object> receiver_map(receiver->map(), isolate_); |
+ code = stub.GetCodeCopyFromTemplate(isolate_); |
+ code->ReplaceNthObject(1, *meta_map, *receiver_map); |
+ code->ReplaceNthObject(1, *cell_map, *cell); |
JSObject::UpdateMapCodeCache(receiver, name, code); |
+ |
return code; |
} |
@@ -922,12 +937,8 @@ Handle<Code> StubCache::ComputeCompareNil(Handle<Map> receiver_map, |
if (!cached_ic.is_null()) return cached_ic; |
} |
- Handle<Code> ic = stub.GetCode(isolate_); |
- |
- // For monomorphic maps, use the code as a template, copying and replacing |
- // the monomorphic map that checks the object's type. |
- ic = isolate_->factory()->CopyCode(ic); |
- ic->ReplaceFirstMap(*receiver_map); |
+ Handle<Code> ic = stub.GetCodeCopyFromTemplate(isolate_); |
+ ic->ReplaceNthObject(1, isolate_->heap()->meta_map(), *receiver_map); |
if (!receiver_map->is_shared()) { |
Map::UpdateCodeCache(receiver_map, name, ic); |