src/ast.cc - Issue 16925008: Generate StoreGlobal stubs with Hydrogen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 16925008: Generate StoreGlobal stubs with Hydrogen (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 589bd5a48f16bc2f892396f4fc3d2b2a99cac6b1..7da9b3366ce18f2ae9968e0e002a7d330864fe20 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -675,6 +675,7 @@ void CallNew::RecordTypeFeedback(TypeFeedbackOracle* oracle) {

if (is_monomorphic_) {

target_ = oracle->GetCallNewTarget(this);

Object* value = allocation_info_cell_->value();

+ ASSERT(!value->IsTheHole());

if (value->IsSmi()) {

elements_kind_ = static_cast<ElementsKind>(Smi::cast(value)->value());

}