Generate StoreGlobal stubs with Hydrogen

src/types.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 284 matching lines @@
   }
 
   return false;
 }
 
 
 bool Type::InUnion(Handle<Unioned> unioned, int current_size) {
   ASSERT(!this->is_union());
   for (int i = 0; i < current_size; ++i) {
     Handle<Type> type = union_get(unioned, i);
-    if (type->is_bitset() ? this->Is(type) : this == *type) return true;
+    if (type->is_bitset()) return this->Is(type);

[rossberg, 2013/06/19 09:45:15]

This whole piece of code should probably be simplified to just

  if (this->Is(type)) return true;

I believe the only reason I special-cased non-bitsets was as a
micro-optimisation, at a point where Is still was slightly more expensive for
the class and constant case than it is now. It no longer seems worth it.

+    if (this == *type) return true;
+    if (type->is_constant()) {
+      if (this->is_constant() && *type->as_constant() == *this->as_constant()) {
+        return true;
+      }
+    }
   }
   return false;
 }
 
 // Get non-bitsets from this which are not subsumed by that, store at unioned,
 // starting at index. Returns updated index.
 int Type::ExtendUnion(Handle<Unioned> result, int current_size) {
   int old_size = current_size;
   if (this->is_class() || this->is_constant()) {
     if (!this->InUnion(result, old_size)) result->set(current_size++, this);
@@ skipping 58 matching lines @@
 }
 
 
 Type* Type::Optional(Handle<Type> type) {
   return type->is_bitset()
       ? from_bitset(type->as_bitset() | kUndefined)
       : Union(type, Undefined()->handle_via_isolate_of(*type));
 }
 
 } }  // namespace v8::internal