Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: Source/bindings/v8/ScriptString.h

Issue 16925002: XMLHttpRequest#responseText should use a rope (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptString.h
diff --git a/Source/core/platform/SerializedResource.h b/Source/bindings/v8/ScriptString.h
similarity index 81%
copy from Source/core/platform/SerializedResource.h
copy to Source/bindings/v8/ScriptString.h
index 76fd022cd596ce5339cf92d1d20761ed0ed411d9..fd54b9ababb84209e0d4fd13f9998ce31869b5e4 100644
--- a/Source/core/platform/SerializedResource.h
+++ b/Source/bindings/v8/ScriptString.h
@@ -28,29 +28,24 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef SerializedResource_h
-#define SerializedResource_h
+#ifndef ScriptString_h
+#define ScriptString_h
-#include "core/platform/SharedBuffer.h"
-#include "weborigin/KURL.h"
+#include "bindings/v8/ScriptValue.h"
+#include "bindings/v8/V8Binding.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
-struct SerializedResource {
- KURL url;
- String mimeType;
- RefPtr<SharedBuffer> data;
+class ScriptString : public ScriptValue {
+public:
+ ScriptString() { }
+ ScriptString(v8::Handle<v8::String> value) : ScriptValue(value) { }
jamesr 2013/06/13 19:28:42 probably want explicit here, no?
abarth-chromium 2013/06/13 19:38:53 Yeah.
- SerializedResource(const KURL& url, const String& mimeType, PassRefPtr<SharedBuffer> data)
- : url(url)
- , mimeType(mimeType)
- , data(data)
- {
- }
+ ScriptString concatenateWith(const String&);
+ String toString() const;
jamesr 2013/06/13 19:28:42 i think this could use a comment indicating that i
abarth-chromium 2013/06/13 19:38:53 Maybe we should call it "flattenToString" ?
};
-}
-
-#endif // SerializedResource_h
+} // namespace WebCore
+#endif // ScriptString_h

Powered by Google App Engine
This is Rietveld 408576698