Source/core/inspector/InspectorConsoleAgent.h - Issue 16925002: XMLHttpRequest#responseText should use a rope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 16925002: XMLHttpRequest#responseText should use a rope (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/ScriptString.cpp ('K') | « Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorConsoleAgent.h

diff --git a/Source/core/inspector/InspectorConsoleAgent.h b/Source/core/inspector/InspectorConsoleAgent.h

index 5baa721add2b63943fca5e0ead475ee45bdea54f..953cc14d44f6f55edf7b9b1d7db75bbada0894b9 100644

--- a/Source/core/inspector/InspectorConsoleAgent.h

+++ b/Source/core/inspector/InspectorConsoleAgent.h

@@ -88,7 +88,7 @@ public:

void frameWindowDiscarded(DOMWindow*);

void didCommitLoad(Frame*, DocumentLoader*);

- void didFinishXHRLoading(ThreadableLoaderClient*, unsigned long requestIdentifier, const String&, const String& url, const String& sendURL, unsigned sendLineNumber);

+ void didFinishXHRLoading(ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const String& url, const String& sendURL, unsigned sendLineNumber);

void didReceiveResourceResponse(unsigned long requestIdentifier, DocumentLoader*, const ResourceResponse& response, ResourceLoader*);

void didFailLoading(unsigned long requestIdentifier, DocumentLoader*, const ResourceError&);

void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, const String& sourceURL);

« Source/bindings/v8/ScriptString.cpp ('K') | « Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »