Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1692483002: Fix adopt-iframe-sec-attr-after-remove.html failure. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix adopt-iframe-sec-attr-after-remove.html failure. Delay GC until back at the event loop. R=haraken BUG=584209 Committed: https://crrev.com/94e93586a5ab1cfd524f09bd501b4f020a0046c1 Cr-Commit-Position: refs/heads/master@{#374872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/adopt-iframe-src-attr-after-remove.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-11 07:54:41 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-11 07:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692483002/1
4 years, 10 months ago (2016-02-11 07:58:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 08:51:48 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94e93586a5ab1cfd524f09bd501b4f020a0046c1
Cr-Commit-Position: refs/heads/master@{#374872}

Powered by Google App Engine
This is Rietveld 408576698