Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp - Issue 16924018: [Binding] Remove signature from domAttribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

Issue 16924018: [Binding] Remove signature from domAttribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/tests/results/V8TestActiveDOMObject.cpp ('K') | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

index d365c6541789aca9a31e90c3b7be4880881eb113..d12404f865104a4984754b229bf9e15b17b49510 100644

--- a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

@@ -150,9 +150,9 @@ static void funcTestInterfaceImplementedAsParamMethodCallback(const v8::Function

} // namespace RealClassV8Internal

static const V8DOMConfiguration::BatchedAttribute V8TestInterfaceImplementedAsAttrs[] = {

- // Attribute 'a' (Type: 'attribute' ExtAttr: '')

+ // Attribute 'a' (Type: 'DOMString' ExtAttr: '')

{"a", RealClassV8Internal::aAttrGetterCallback, RealClassV8Internal::aAttrSetterCallback, 0, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

- // Attribute 'b' (Type: 'attribute' ExtAttr: '')

+ // Attribute 'b' (Type: 'TestInterfaceImplementedAs' ExtAttr: '')

{"b", RealClassV8Internal::bAttrGetterCallback, RealClassV8Internal::bAttrSetterCallback, 0, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

};