Source/bindings/tests/results/V8TestException.cpp - Issue 16924018: [Binding] Remove signature from domAttribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestException.cpp

Issue 16924018: [Binding] Remove signature from domAttribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/tests/results/V8TestActiveDOMObject.cpp ('K') | « Source/bindings/tests/results/V8TestEventConstructor.cpp ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestException.cpp

diff --git a/Source/bindings/tests/results/V8TestException.cpp b/Source/bindings/tests/results/V8TestException.cpp

index 84a9dcc7dd72457809c17e2d4639157f651b578f..ce54b46918109ec1cd2aafbd48975aad8a5d15f8 100644

--- a/Source/bindings/tests/results/V8TestException.cpp

+++ b/Source/bindings/tests/results/V8TestException.cpp

@@ -74,7 +74,7 @@ static void nameAttrGetterCallback(v8::Local<v8::String> name, const v8::Propert

} // namespace TestExceptionV8Internal

static const V8DOMConfiguration::BatchedAttribute V8TestExceptionAttrs[] = {

- // Attribute 'name' (Type: 'attribute' ExtAttr: '')

+ // Attribute 'name' (Type: 'DOMString' ExtAttr: '')

{"name", TestExceptionV8Internal::nameAttrGetterCallback, 0, 0, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

};