Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: Source/bindings/tests/results/V8TestActiveDOMObject.cpp

Issue 16924018: [Binding] Remove signature from domAttribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestActiveDOMObject.cpp
diff --git a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp b/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
index 9fb4aa8b9aac0d3891f8d09e1513fa3b54081f9b..47ea24d05a38dbe090cd83d46d4f9edae49f6d8f 100644
--- a/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
+++ b/Source/bindings/tests/results/V8TestActiveDOMObject.cpp
@@ -176,7 +176,7 @@ static void TestActiveDOMObjectDomainSafeFunctionSetter(v8::Local<v8::String> na
} // namespace TestActiveDOMObjectV8Internal
static const V8DOMConfiguration::BatchedAttribute V8TestActiveDOMObjectAttrs[] = {
- // Attribute 'excitingAttr' (Type: 'attribute' ExtAttr: '')
kojih 2013/06/17 04:44:33 Originally attribute->type was always 'attribute'
haraken 2013/06/17 04:49:08 Actually, I think we can simply remove the '(Type:
+ // Attribute 'excitingAttr' (Type: 'long' ExtAttr: '')
{"excitingAttr", TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallback, 0, 0, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
};
« no previous file with comments | « Source/bindings/scripts/generate-bindings.pl ('k') | Source/bindings/tests/results/V8TestEventConstructor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698