[Binding] Remove signature from domAttribute

[Binding] Remove signature from domAttribute

Currently domAttribute has 'signature' and
it is used for holding type, name and extended attributes.
But it is not necessary to use 'signature' to hold those.

This patch improve situation by 
- removing signature from domAttribute
- adding name, isNullable, extendedAttributes to domAttribute

Generated code is same as before except for comment of attributes.

R=haraken@chromium.org
BUG=239771
TEST=TestActiveDOMObject.idl
     TestEventConstructor.idl
     TestException.idl
     TestInterface.idl
     TestInterfaceImplementedAs.idl
     TestObject.idl
     TestSerializedScriptValueInterface.idl
     TestTypedefs.idl

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152528

[kojih, 2013-06-17 04:44:33]

r?

https://codereview.chromium.org/16924018/diff/1/Source/bindings/tests/results...
File Source/bindings/tests/results/V8TestActiveDOMObject.cpp (left):

https://codereview.chromium.org/16924018/diff/1/Source/bindings/tests/results...
Source/bindings/tests/results/V8TestActiveDOMObject.cpp:179: // Attribute
'excitingAttr' (Type: 'attribute' ExtAttr: '')
Originally attribute->type was always 'attribute'
and attribute->signature->type was actual type.
Generator used attribute->type for generating this comment.
Therefore "Type: 'attribute'" was generated (which seems meaningless)

With this patch, attribute->type holds actual type,
so type in comment is now actual type.

[haraken, 2013-06-17 04:49:08]

LGTM

https://codereview.chromium.org/16924018/diff/1/Source/bindings/tests/results...
File Source/bindings/tests/results/V8TestActiveDOMObject.cpp (left):

https://codereview.chromium.org/16924018/diff/1/Source/bindings/tests/results...
Source/bindings/tests/results/V8TestActiveDOMObject.cpp:179: // Attribute
'excitingAttr' (Type: 'attribute' ExtAttr: '')

Actually, I think we can simply remove the '(Type: ...)' part of this comment.
Currently, changing IDL attributes in an IDL file changes the comment, which
causes rebuild of the generated code. It's ridiculous.

[commit-bot: I haz the power, 2013-06-17 05:03:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/16924018/6001

[commit-bot: I haz the power, 2013-06-17 06:39:09]

Failed to apply patch for Source/bindings/scripts/CodeGeneratorV8.pm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/scripts/CodeGeneratorV8.pm
  Hunk #3 succeeded at 1304 (offset 8 lines).
  Hunk #4 succeeded at 1338 (offset 8 lines).
  Hunk #5 succeeded at 1348 (offset 8 lines).
  Hunk #6 succeeded at 1392 (offset 8 lines).
  Hunk #7 succeeded at 1406 (offset 8 lines).
  Hunk #8 succeeded at 1424 (offset 8 lines).
  Hunk #9 FAILED at 1435.
  Hunk #10 succeeded at 1461 (offset 9 lines).
  Hunk #11 FAILED at 1461.
  Hunk #12 succeeded at 1495 (offset 9 lines).
  Hunk #13 succeeded at 1558 (offset 9 lines).
  Hunk #14 succeeded at 1592 (offset 9 lines).
  Hunk #15 succeeded at 1601 (offset 9 lines).
  Hunk #16 succeeded at 1622 (offset 9 lines).
  Hunk #17 succeeded at 1727 (offset 9 lines).
  Hunk #18 succeeded at 1760 (offset 9 lines).
  Hunk #19 succeeded at 1779 (offset 9 lines).
  Hunk #20 succeeded at 1811 (offset 9 lines).
  Hunk #21 FAILED at 1825.
  Hunk #22 succeeded at 1871 (offset 9 lines).
  Hunk #23 FAILED at 1879.
  Hunk #24 FAILED at 1897.
  Hunk #25 succeeded at 1917 (offset 10 lines).
  Hunk #26 succeeded at 1929 (offset 10 lines).
  Hunk #27 succeeded at 1943 (offset 10 lines).
  Hunk #28 succeeded at 2702 (offset 10 lines).
  Hunk #29 succeeded at 2890 (offset 10 lines).
  Hunk #30 succeeded at 2907 (offset 10 lines).
  Hunk #31 succeeded at 2939 (offset 10 lines).
  Hunk #32 succeeded at 2956 (offset 10 lines).
  Hunk #33 succeeded at 2998 (offset 10 lines).
  Hunk #34 succeeded at 3749 (offset 10 lines).
  Hunk #35 FAILED at 3867.
  Hunk #36 succeeded at 4087 (offset 11 lines).
  Hunk #37 succeeded at 4214 (offset 11 lines).
  Hunk #38 succeeded at 5664 (offset 12 lines).
  Hunk #39 succeeded at 5688 (offset 12 lines).
  Hunk #40 succeeded at 5702 (offset 12 lines).
  Hunk #41 succeeded at 5716 (offset 12 lines).
  Hunk #42 succeeded at 5759 (offset 12 lines).
  6 out of 42 hunks FAILED -- saving rejects to file
Source/bindings/scripts/CodeGeneratorV8.pm.rej

Patch:       Source/bindings/scripts/CodeGeneratorV8.pm
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm
b/Source/bindings/scripts/CodeGeneratorV8.pm
index
70dc7c851f524a990c3b6e22adde008e33b29cf0..98714040436489a053cd846c29ae33e1abafbdec
100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -726,9 +726,9 @@ END
 
     my @enabledPerContextAttributes;
     foreach my $attribute (@{$interface->attributes}) {
-        my $name = $attribute->signature->name;
-        my $attrExt = $attribute->signature->extendedAttributes;
-        my $conditionalString =
GenerateConditionalString($attribute->signature);
+        my $name = $attribute->name;
+        my $attrExt = $attribute->extendedAttributes;
+        my $conditionalString = GenerateConditionalString($attribute);
         if (HasCustomGetter($attrExt) && !$attrExt->{"ImplementedBy"}) {
             $header{classPublic}->add("#if ${conditionalString}\n") if
$conditionalString;
             $header{classPublic}->add(<<END);
@@ -1103,7 +1103,7 @@ sub HasCustomMethod
 sub IsReadonly
 {
     my $attribute = shift;
-    my $attrExt = $attribute->signature->extendedAttributes;
+    my $attrExt = $attribute->extendedAttributes;
     return $attribute->isReadOnly && !$attrExt->{"Replaceable"};
 }
 
@@ -1296,10 +1296,10 @@ sub GenerateNormalAttrGetterCallback
 
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
-    my $attrExt = $attribute->signature->extendedAttributes;
-    my $attrName = $attribute->signature->name;
+    my $attrExt = $attribute->extendedAttributes;
+    my $attrName = $attribute->name;
 
-    my $conditionalString = GenerateConditionalString($attribute->signature);
+    my $conditionalString = GenerateConditionalString($attribute);
     my $code = "";
     $code .= "#if ${conditionalString}\n\n" if $conditionalString;
 
@@ -1330,9 +1330,9 @@ sub GenerateNormalAttrGetter
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
-    my $attrExt = $attribute->signature->extendedAttributes;
-    my $attrName = $attribute->signature->name;
-    my $attrType = $attribute->signature->type;
+    my $attrExt = $attribute->extendedAttributes;
+    my $attrName = $attribute->name;
+    my $attrType = $attribute->type;
 
     if (HasCustomGetter($attrExt)) {
         return;
@@ -1340,10 +1340,10 @@ sub GenerateNormalAttrGetter
 
     AssertNotSequenceType($attrType);
     my $getterStringUsesImp = $interfaceName ne "SVGNumber";
-    my $nativeType = GetNativeTypeFromSignature($attribute->signature, -1);
+    my $nativeType = GetNativeTypeFromSignature($attribute, -1);
     my $svgNativeType = GetSVGTypeNeedingTearOff($interfaceName);
 
-    my $conditionalString = GenerateConditionalString($attribute->signature);
+    my $conditionalString = GenerateConditionalString($attribute);
     my $code = "";
     $code .= "#if ${conditionalString}\n\n" if $conditionalString;
     $code .= <<END;
@@ -1384,8 +1384,8 @@ END
     ${implClassName}* imp = ${v8ClassName}::toNative(holder);
 END
     } else {
-        my $reflect = $attribute->signature->extendedAttributes->{"Reflect"};
-        my $url = $attribute->signature->extendedAttributes->{"URL"};
+        my $reflect = $attribute->extendedAttributes->{"Reflect"};
+        my $url = $attribute->extendedAttributes->{"URL"};
         if ($getterStringUsesImp && $reflect && !$url &&
InheritsInterface($interface, "Node") && $attrType eq "DOMString") {
             # Generate super-compact call for regular attribute getter:
             my ($functionName, @arguments) = GetterExpression($interfaceName,
$attribute);
@@ -1398,7 +1398,7 @@ END
             return;
             # Skip the rest of the function!
         }
-        if ($attribute->signature->type eq "SerializedScriptValue" &&
$attrExt->{"CachedAttribute"}) {
+        if ($attribute->type eq "SerializedScriptValue" &&
$attrExt->{"CachedAttribute"}) {
             $code .= <<END;
     v8::Handle<v8::String> propertyName = v8::String::NewSymbol("${attrName}");
     v8::Handle<v8::Value> value = info.Holder()->GetHiddenValue(propertyName);
@@ -1416,16 +1416,16 @@ END
     }
 
     # Generate security checks if necessary
-    if ($attribute->signature->extendedAttributes->{"CheckSecurityForNode"}) {
+    if ($attribute->extendedAttributes->{"CheckSecurityForNode"}) {
         AddToImplIncludes("bindings/v8/BindingSecurity.h");
-        $code .= "    if (!BindingSecurity::shouldAllowAccessToNode(imp->" .
GetImplName($attribute->signature) . "())) {\n";
+        $code .= "    if (!BindingSecurity::shouldAllowAccessToNode(imp->" .
GetImplName($attribute) . "())) {\n";
         $code .= "        v8SetReturnValueNull(info);\n";
         $code .= "        return;\n";
         $code .= "    }\n";
     }
 
-    my $useExceptions = 1 if
$attribute->signature->extendedAttributes->{"GetterRaisesException"} || 
$attribute->signature->extendedAttributes->{"RaisesException"};
-    my $isNullable = $attribute->signature->isNullable;
+    my $useExceptions = 1 if
$attribute->extendedAttributes->{"GetterRaisesException"} || 
$attribute->extendedAttributes->{"RaisesException"};
+    my $isNullable = $attribute->isNullable;
     if ($useExceptions) {
         AddToImplIncludes("core/dom/ExceptionCode.h");
         $code .= "    ExceptionCode ec = 0;\n";
@@ -1435,15 +1435,15 @@ END
         $code .= "    bool isNull = false;\n";
     }
 
-    my $returnType = $attribute->signature->type;
+    my $returnType = $attribute->type;
     my $getterString;
 
     if ($getterStringUsesImp) {
         my ($functionName, @arguments) = GetterExpression($interfaceName,
$attribute);
         push(@arguments, "isNull") if $isNullable;
         push(@arguments, "ec") if $useExceptions;
-        if ($attribute->signature->extendedAttributes->{"ImplementedBy"}) {
-            my $implementedBy =
$attribute->signature->extendedAttributes->{"ImplementedBy"};
+        if ($attribute->extendedAttributes->{"ImplementedBy"}) {
+            my $implementedBy =
$attribute->extendedAttributes->{"ImplementedBy"};
             AddToImplIncludes(HeaderFilesForInterface($implementedBy,
$implementedBy));
             unshift(@arguments, "imp") if !$attribute->isStatic;
             $functionName = "${implementedBy}::${functionName}";
@@ -1452,7 +1452,7 @@ END
         } else {
             $functionName = "imp->${functionName}";
         }
-        my ($arg, $subCode) =
GenerateCallWith($attribute->signature->extendedAttributes->{"CallWith"}, "   
", 0);
+        my ($arg, $subCode) =
GenerateCallWith($attribute->extendedAttributes->{"CallWith"}, "    ", 0);
         $code .= $subCode;
         unshift(@arguments, @$arg);
         $getterString = "${functionName}(" . join(", ", @arguments) . ")";
@@ -1461,14 +1461,14 @@ END
     }
 
     my $expression;
-    if ($attribute->signature->type eq "EventListener" && $interface->name eq
"DOMWindow") {
+    if ($attribute->type eq "EventListener" && $interface->name eq "DOMWindow")
{
         $code .= "    if (!imp->document())\n";
         $code .= "        return;\n";
     }
 
     if ($useExceptions || $isNullable) {
         if ($nativeType =~ /^V8StringResource/) {
-            $code .= "    " . ConvertToV8StringResource($attribute->signature,
$nativeType, "v", $getterString) . ";\n";
+            $code .= "    " . ConvertToV8StringResource($attribute,
$nativeType, "v", $getterString) . ";\n";
         } else {
             $code .= "    $nativeType v = $getterString;\n";
         }
@@ -1486,7 +1486,7 @@ END
             $code .= "        return;\n";
             $code .= "    };\n";
 
-            if
(ExtendedAttributeContains($attribute->signature->extendedAttributes->{"Call…
(message too large)

[commit-bot: I haz the power, 2013-06-17 06:49:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/16924018/15001

[commit-bot: I haz the power, 2013-06-17 06:49:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/16924018/15001

[commit-bot: I haz the power, 2013-06-17 08:09:37]

Change committed as 152528