Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1692383002: Revert of Make instrumentation_test_apk depend on their apk_under_test. (Closed)

Created:
4 years, 10 months ago by jbudorick
Modified:
4 years, 10 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dist-jar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make instrumentation_test_apk depend on their apk_under_test. (patchset #2 id:70001 of https://codereview.chromium.org/1690983002/ ) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=586641 Original issue's description: > Reland #2 of Tweak GN deps of instrumentation apks > > Reland of https://codereview.chromium.org/1687723002/ > > This improves build concurrency a little bit. > > BUG=none TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/fba1adc4a38a497e2a012613313e5433a778af11 Cr-Commit-Position: refs/heads/master@{#375272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M build/android/gyp/write_build_config.py View 2 chunks +2 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 3 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jbudorick
Created Revert of Make instrumentation_test_apk depend on their apk_under_test.
4 years, 10 months ago (2016-02-12 22:11:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692383002/1
4 years, 10 months ago (2016-02-12 22:12:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 22:14:09 UTC) #3
agrieve
On 2016/02/12 22:14:09, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) lgtm. ...
4 years, 10 months ago (2016-02-12 22:31:47 UTC) #4
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1702663002/ by agrieve@chromium.org. ...
4 years, 10 months ago (2016-02-16 16:26:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:45:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fba1adc4a38a497e2a012613313e5433a778af11
Cr-Commit-Position: refs/heads/master@{#375272}

Powered by Google App Engine
This is Rietveld 408576698