ui/views/BUILD.gn - Issue 1692363003: Convert views_unittests to run exclusively on Swarming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/BUILD.gn

Issue 1692363003: Convert views_unittests to run exclusively on Swarming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gnnn Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/BUILD.gn

diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn

index 8741bec7e1a437bd3c47405f39da078ffe417356..5c471a5b1aa068ea895b68614c59991a407f1a70 100644

--- a/ui/views/BUILD.gn

+++ b/ui/views/BUILD.gn

@@ -231,8 +231,10 @@ test("views_unittests") {

"//url",

]

- data_deps = [

- "//ui/resources:ui_test_pak",

+ # TODO(thakis): This should be a data_deps on //ui/resources:ui_test_pak, but

+ # that has no effect. (See similar TODOs elsewhere ui_test.pak is listed)

+ data = [

+ "$root_out_dir/ui_test.pak",

]

if (is_win) {

« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | ui/views/views.gyp » ('j') | no next file with comments »