Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1692363003: Convert views_unittests to run exclusively on Swarming (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert views_unittests to run exclusively on Swarming 1 configs already ran on Swarming 37 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinAsanCov tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.fyi.json: MD Top Chrome ChromeOS non-material - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.webkit.json: WebKit Linux Oilpan - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) Ran: ./manage.py --convert views_unittests BUG=98637 Committed: https://crrev.com/0d2610f23f93aefa30d585d6c26688be110a8034 Cr-Commit-Position: refs/heads/master@{#375487}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : gah #

Patch Set 5 : hmm #

Patch Set 6 : pak #

Patch Set 7 : osmesa #

Patch Set 8 : gnnn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -6 lines) Patch
M build/gn_migration.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 21 chunks +63 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A + ui/views/views_unittests.isolate View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
4 years, 10 months ago (2016-02-15 19:28:44 UTC) #2
Nico
oh, and +maruel too
4 years, 10 months ago (2016-02-15 19:29:23 UTC) #4
M-A Ruel
thanks! lgtm
4 years, 10 months ago (2016-02-15 19:35:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692363003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692363003/140001
4 years, 10 months ago (2016-02-15 19:42:50 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 10 months ago (2016-02-15 20:11:17 UTC) #8
Dirk Pranke
hm, didn't realize views wasn't running under swarming on the linux bots :(. lgtm.
4 years, 10 months ago (2016-02-16 20:43:35 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:44 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/0d2610f23f93aefa30d585d6c26688be110a8034
Cr-Commit-Position: refs/heads/master@{#375487}

Powered by Google App Engine
This is Rietveld 408576698