Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: net/base/ip_address_unittest.cc

Issue 1692353002: Make IP Address related functions return the empty string when used on an invalid address. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_address_unittest.cc
diff --git a/net/base/ip_address_unittest.cc b/net/base/ip_address_unittest.cc
index ad3db3e28b245281d2aa7aff5b4231ed7394ae18..b08d10a74fdb15868b62a9c179034b4ba2afd39e 100644
--- a/net/base/ip_address_unittest.cc
+++ b/net/base/ip_address_unittest.cc
@@ -94,6 +94,14 @@ TEST(IPAddressTest, ToString) {
uint8_t addr3[16] = {0xFE, 0xDC, 0xBA, 0x98};
IPAddress ip_address3(addr3);
EXPECT_EQ("fedc:ba98::", ip_address3.ToString());
+
+ // ToString() shouldn't crash on invalid addresses.
+ uint8_t addr4[2];
+ IPAddress ip_address4(addr4);
+ EXPECT_EQ("", ip_address4.ToString());
+
+ IPAddress ip_address5;
+ EXPECT_EQ("", ip_address5.ToString());
}
// Test that invalid IP literals fail to parse.
@@ -178,6 +186,10 @@ TEST(IPAddressTest, IPAddressToStringWithPort) {
IPAddress address3;
EXPECT_TRUE(address3.AssignFromIPLiteral("fedc:ba98::"));
EXPECT_EQ("[fedc:ba98::]:8080", IPAddressToStringWithPort(address3, 8080));
+
+ // ToString() shouldn't crash on invalid addresses.
+ IPAddress address4;
+ EXPECT_EQ("", IPAddressToStringWithPort(address4, 8080));
}
TEST(IPAddressTest, IPAddressToPackedString) {

Powered by Google App Engine
This is Rietveld 408576698