tools/gn/bootstrap/base/generated_build_date.h - Issue 1692303004: Update GN bootstrap build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/bootstrap/base/generated_build_date.h

Issue 1692303004: Update GN bootstrap build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use real BUILD_DATE Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BUILD_DATE

	6 #error BUILD_DATE must be defined by bootstrap.py
	tfarina 2016/02/14 20:10:59 Why do we need this file? It is not clear to me, m Why do we need this file? It is not clear to me, maybe it is to Brett, but I think for future readers, it would be good if you could explain why we need this pseudo generated file. NGG 2016/02/15 13:06:16 Done. Show quoted text On 2016/02/14 20:10:59, tfarina wrote: > Why do we need this file? It is not clear to me, maybe it is to Brett, but I > think for future readers, it would be good if you could explain why we need this > pseudo generated file. Done.
	7 #endif // BUILD_DATE

OLD	NEW

« no previous file with comments | « AUTHORS ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »