tools/gn/bootstrap/base/generated_build_date.h - Issue 1692303004: Update GN bootstrap build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/gn/bootstrap/base/generated_build_date.h

Issue 1692303004: Update GN bootstrap build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add description to generated_build_date.h Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	tfarina 2016/02/16 14:47:05 Btw, how come build_date.cc is seeing this file in Btw, how come build_date.cc is seeing this file in tools/gn/bootstrap? Is tools/gn/bootstrap being included in -I path? If so, could you show me where? Otherwise, I don't see how is is possible be working. Perhaps paste the command line that bootstrap is using to compile it, just for us to see what it is doing.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // When building Chromium with GN, this file is generated by

	6 // the //base:build_date action and it contains an approximate build date.

	7 // For GN bootstrapping we still need this file to be available

	8 // because it is included from base/build_time.cc, but the actual

	9 // BUILD_DATE define is given as a compiler option set by bootstrap.py.

	10 #ifndef BUILD_DATE

	11 #error BUILD_DATE must be defined by bootstrap.py

	12 #endif // BUILD_DATE

OLD	NEW

« no previous file with comments | « AUTHORS ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »