rework LocalLibraryContributor to resolve referenced units

rework LocalLibraryContributor to resolve referenced units
This is similar reworking code completion import resolution
https://codereview.chromium.org/1693933002/

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/748ad91b645a9356270f3cde075978bb4018646b

[danrubel, 2016-02-12 20:28:40]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-12 20:42:07]

LGTM

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:284:
'resolve library unit');
Do we want to checkAborted() after returning from an async call?

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:286:
resolvedUnits.add(resolvedUnit);
Do we want to check for null before adding the unit to the list? I know we test
for it later, but it might be better to test for it here.

[danrubel, 2016-02-12 20:54:23]

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:284:
'resolve library unit');
On 2016/02/12 20:42:07, Brian Wilkerson wrote:
> Do we want to checkAborted() after returning from an async call?

Good catch! Done.

https://codereview.chromium.org/1692273003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:286:
resolvedUnits.add(resolvedUnit);
On 2016/02/12 20:42:07, Brian Wilkerson wrote:
> Do we want to check for null before adding the unit to the list? I know we
test
> for it later, but it might be better to test for it here.

Good idea. Done.

[danrubel, 2016-02-14 04:07:22]

Description was changed from

==========
rework LocalLibraryContributor to resolve referenced units
This is similar reworking code completion import resolution
https://codereview.chromium.org/1693933002/
==========

to

==========
rework LocalLibraryContributor to resolve referenced units
This is similar reworking code completion import resolution
https://codereview.chromium.org/1693933002/

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/748ad91b645a9356270f3cde075978bb4018646b
==========

[danrubel, 2016-02-14 04:07:23]

Committed patchset #4 (id:60001) manually as
748ad91b645a9356270f3cde075978bb4018646b (presubmit successful).