QUIC - chromium server push support.

net/quic/quic_stream_factory.h

Index: net/quic/quic_stream_factory.h
diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h
index b05dc1f0f2ceae52bbf0d6611412353a98ee7824..9be5808b98a805e574144c509af35b667bfa768c 100644
--- a/net/quic/quic_stream_factory.h
+++ b/net/quic/quic_stream_factory.h
@@ -78,6 +78,7 @@ class NET_EXPORT_PRIVATE QuicStreamRequest {
               int cert_verify_flags,
               base::StringPiece origin_host,

[Ryan Hamilton, 2016/02/24 00:34:00]

I suspect we don't need origin host if we're now passing in the URL. (Should the
URL be a GURL?

[Buck, 2016/02/26 23:54:17]

Done.

               base::StringPiece method,
+              const string& url,
               const BoundNetLog& net_log,
               const CompletionCallback& callback);
 
@@ -101,6 +102,7 @@ class NET_EXPORT_PRIVATE QuicStreamRequest {
   QuicStreamFactory* factory_;
   HostPortPair host_port_pair_;
   std::string origin_host_;
+  string url_;
   PrivacyMode privacy_mode_;
   BoundNetLog net_log_;
   CompletionCallback callback_;
@@ -173,6 +175,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
              int cert_verify_flags,
              base::StringPiece origin_host,
              base::StringPiece method,
+             const std::string& url,
              const BoundNetLog& net_log,
              QuicStreamRequest* request);
 
@@ -527,6 +530,8 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
 
   NetworkConnection network_connection_;
 
+  int num_push_streams_created_;

[Ryan Hamilton, 2016/02/24 00:34:00]

What is this variable used for?

[Buck, 2016/02/26 23:54:17]

Used in quic_http_stream_test.cc via
QuicStreamFactoryPeer::GetNumPushStreamsCreated().

[Ryan Hamilton, 2016/02/29 17:49:40]

This is totally a minor point, but I don't usually love test-only code in
non-test classes. How hard would it be to make the test work w/o this? Maybe not
worth it?

[Buck, 2016/02/29 19:03:01]

I took another look, and I don't see an easy way to make the test work
otherwise.   It *might* have non-debug value when I add UMA instrumentation... 

+
   QuicClientPushPromiseIndex push_promise_index_;
 
   base::TaskRunner* task_runner_;