QUIC - chromium server push support.

net/quic/quic_http_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_HTTP_STREAM_H_
 #define NET_QUIC_QUIC_HTTP_STREAM_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <list>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/io_buffer.h"
 #include "net/http/http_stream.h"
 #include "net/quic/quic_chromium_client_session.h"
 #include "net/quic/quic_chromium_client_stream.h"
+#include "net/quic/quic_client_push_promise_index.h"
 
 namespace net {
 
 namespace test {
 class QuicHttpStreamPeer;
 }  // namespace test
 
 // The QuicHttpStream is a QUIC-specific HttpStream subclass.  It holds a
 // non-owning pointer to a QuicChromiumClientStream which it uses to
 // send and receive data.
 class NET_EXPORT_PRIVATE QuicHttpStream
     : public QuicChromiumClientSession::Observer,
       public QuicChromiumClientStream::Delegate,
+      public QuicClientPushPromiseIndex::Delegate,
       public HttpStream {
  public:
   explicit QuicHttpStream(
       const base::WeakPtr<QuicChromiumClientSession>& session);
 
   ~QuicHttpStream() override;
 
   // HttpStream implementation.
   int InitializeStream(const HttpRequestInfo* request_info,
                        RequestPriority priority,
@@ skipping 30 matching lines @@
                           size_t frame_len) override;
   void OnDataAvailable() override;
   void OnClose(QuicErrorCode error) override;
   void OnError(int error) override;
   bool HasSendHeadersComplete() override;
 
   // QuicChromiumClientSession::Observer implementation
   void OnCryptoHandshakeConfirmed() override;
   void OnSessionClosed(int error) override;
 
+  // QuicClientPushPromiseIndex::Delegate implementation
+  bool CheckVary(const SpdyHeaderBlock& client_request,
+                 const SpdyHeaderBlock& promise_request,
+                 const SpdyHeaderBlock& promise_response) override;
+  void OnRendezvousResult(QuicSpdyStream* stream) override;
+
  private:
   friend class test::QuicHttpStreamPeer;
 
   enum State {
     STATE_NONE,
+    STATE_STREAM_REQUEST,

[Ryan Hamilton, 2016/02/24 00:34:00]

Perhaps this should be STATE_REQUEST_STREAM to be of the form
STATE_<verb>_<noun>

[Buck, 2016/02/26 23:54:16]

Done.

     STATE_SEND_HEADERS,
     STATE_SEND_HEADERS_COMPLETE,
     STATE_READ_REQUEST_BODY,
     STATE_READ_REQUEST_BODY_COMPLETE,
     STATE_SEND_BODY,
     STATE_SEND_BODY_COMPLETE,
     STATE_OPEN,
   };
 
   void OnStreamReady(int rv);
   void OnIOComplete(int rv);
   void DoCallback(int rv);
 
   int DoLoop(int);
+  int DoStreamRequest();
   int DoSendHeaders();
   int DoSendHeadersComplete(int rv);
   int DoReadRequestBody();
   int DoReadRequestBodyComplete(int rv);
   int DoSendBody();
   int DoSendBodyComplete(int rv);
   int DoReadResponseHeaders();
   int DoReadResponseHeadersComplete(int rv);
 
   int ProcessResponseHeaders(const SpdyHeaderBlock& headers);
 
   int ReadAvailableData(IOBuffer* buf, int buf_len);
+  void EnterStateSendHeaders();
+  int HandlePromise();
 
   void ResetStream();
 
+  void ConvertHeaderBlockToHttpRequestHeaders(
+      const SpdyHeaderBlock& spdy_headers,
+      HttpRequestHeaders* http_headers);

[Ryan Hamilton, 2016/02/24 00:34:00]

Consider adding this method to:

net/spdy/spdy_http_utils.h

It looks like the other 3 methods already exist :>

[Buck, 2016/02/26 23:54:16]

Done.

+
   State next_state_;
 
   base::WeakPtr<QuicChromiumClientSession> session_;
   int session_error_;             // Error code from the connection shutdown.
   bool was_handshake_confirmed_;  // True if the crypto handshake succeeded.
   QuicChromiumClientSession::StreamRequest stream_request_;
   QuicChromiumClientStream* stream_;  // Non-owning.
 
   // The following three fields are all owned by the caller and must
   // outlive this object, according to the HttpStream contract.
@@ skipping 48 matching lines @@
   BoundNetLog stream_net_log_;
 
   QuicErrorCode quic_connection_error_;
 
   // SSLInfo from the underlying QuicSession.
   SSLInfo ssl_info_;
 
   // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
   bool read_in_progress_ = false;
 
+  bool found_promise_;
+  QuicClientPushPromiseIndex::TryHandle* push_handle_;

[Ryan Hamilton, 2016/02/24 00:34:00]

Can you comment on ownership of this object, and under what circumstances it
will be set.

[Buck, 2016/02/26 23:54:16]

Done.

+
   base::WeakPtrFactory<QuicHttpStream> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicHttpStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_HTTP_STREAM_H_