[Android] Add compile target -> old name map for instrumentation tests.

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import string
 
 
 class Test(object):
   """
@@ skipping 1503 matching lines @@
     mock_test_results = {
       'per_iteration_data': [{'TestA': [{'status': 'SUCCESS'}]},
                              {'TestB': [{'status': 'FAILURE'}]}]
     }
     api.chromium_android.run_java_unit_test_suite(
         self.name, verbose=True, suffix=suffix,
         json_results_file=json_results_file,
         step_test_data=lambda: api.json.test_api.output(mock_test_results))
 
 
-# Provide a 1:1 mapping between CamelCase and snake_case instrumentation test
-# names. This provides a migration path to using swarming+isolates, which
-# specify additional build targets in src/ instead of here.
-ANDROID_INSTRUMENTATION_TARGET_MAP = {

[ghost stip (do not use), 2016/03/01 15:54:52]

I pulled these out of the class because I needed to write a second, swarmed
class which had to read this data. I guess if we switch to non-camel I won't
need this though.

[jbudorick, 2016/03/01 16:14:45]

yeah, I was thinking that you'd be able to just do

  swarming_target = 'run_%' % name

once name is the compile target rather than camel case.

-    'AndroidWebViewTest': 'android_webview_test_apk',
-    'ChromePublicTest': 'chrome_public_test_apk',
-    'ChromeSyncShellTest': 'chrome_sync_shell_test_apk',
-    'ChromotingTest': 'remoting_test_apk',
-    'ContentShellTest': 'content_shell_test_apk',
-    'MojoTest': 'mojo_test_apk',
-    'SystemWebViewShellLayoutTest': 'system_webview_shell_layout_test_apk',
-}
-
-
 class AndroidInstrumentationTest(AndroidTest):
   _DEFAULT_SUITES = {
     'AndroidWebViewTest': {
+      'compile_target': 'android_webview_test_apk',
       'isolate_file_path': 'android_webview/android_webview_test_apk.isolate',
       'apk_under_test': 'AndroidWebView.apk',
       'test_apk': 'AndroidWebViewTest.apk',
     },
     'ChromePublicTest': {
+      'compile_target': 'chrome_public_test_apk',
       'isolate_file_path': 'chrome/chrome_public_test_apk.isolate',
       'apk_under_test': 'ChromePublic.apk',
       'test_apk': 'ChromePublicTest.apk',
       'additional_apks': [
         'ChromePublicTestSupport.apk',
         'ChromiumNetTestSupport.apk',
       ],
     },
     'ChromeSyncShellTest': {
+      'compile_target': 'chrome_sync_shell_test_apk',
       'isolate_file_path': None,
       'apk_under_test': 'ChromeSyncShell.apk',
       'test_apk': 'ChromeSyncShellTest.apk',
     },
     'ChromotingTest': {
+      'compile_target': 'remoting_test_apk',
       'isolate_file_path': None,
       'apk_under_test': 'Chromoting.apk',
       'test_apk': 'ChromotingTest.apk',
     },
     'ContentShellTest': {
+      'compile_target': 'content_shell_test_apk',
       'isolate_file_path': 'content/content_shell_test_apk.isolate',
       'apk_under_test': 'ContentShell.apk',
       'test_apk': 'ContentShellTest.apk',
     },
     'SystemWebViewShellLayoutTest': {
-      'extra_compile_targets': ['system_webview_apk',
-                                'system_webview_shell_apk',
-                                'android_tools'],
+      'compile_target': 'system_webview_shell_layout_test_apk',
+      'additional_compile_targets': [
+        'system_webview_apk',
+        'system_webview_shell_apk',
+        'android_tools'
+      ],
       'isolate_file_path': ('android_webview/'
                             'system_webview_shell_test_apk.isolate'),
       'apk_under_test': 'SystemWebViewShell.apk',
       'test_apk': 'SystemWebViewShellLayoutTest.apk',
       'additional_apks': ['SystemWebView.apk'],
     },
     'MojoTest': {
+      'compile_target': 'mojo_test_apk',
       'isolate_file_path': None,
       'apk_under_test': None,
       'test_apk': 'MojoTest.apk',
     }
   }
 
+  _DEFAULT_SUITES_BY_TARGET = {

[ghost stip (do not use), 2016/03/01 15:54:52]

Ideally we can delete once we're only using snake_case?

[jbudorick, 2016/03/01 16:14:45]

yeah, I've only got both here for the src-side transition.

+    'android_webview_test_apk': _DEFAULT_SUITES['AndroidWebViewTest'],
+    'chrome_public_test_apk': _DEFAULT_SUITES['ChromePublicTest'],
+    'chrome_sync_shell_test_apk': _DEFAULT_SUITES['ChromeSyncShellTest'],
+    'content_shell_test_apk': _DEFAULT_SUITES['ContentShellTest'],
+    'mojo_test_apk': _DEFAULT_SUITES['MojoTest'],
+    'remoting_test_apk': _DEFAULT_SUITES['ChromotingTest'],
+    'system_webview_shell_layout_test_apk': _DEFAULT_SUITES['SystemWebViewShellLayoutTest'],

[ghost stip (do not use), 2016/03/01 15:54:52]

nit: 80

[jbudorick, 2016/03/01 16:14:45]

Done.

+  }
+
   def __init__(self, name, compile_targets=None, apk_under_test=None,
                test_apk=None, isolate_file_path=None, timeout_scale=None,
                flakiness_dashboard='test-results.appspot.com',
                annotation=None, except_annotation=None, screenshot=False,
                verbose=True, tool=None, host_driven_root=None,
                additional_apks=None):
-    suite_defaults = AndroidInstrumentationTest._DEFAULT_SUITES.get(name, {})
+    suite_defaults = (AndroidInstrumentationTest._DEFAULT_SUITES.get(name)
+                      or AndroidInstrumentationTest._DEFAULT_SUITES_BY_TARGET.get(name)

[ghost stip (do not use), 2016/03/01 15:54:52]

80

[jbudorick, 2016/03/01 16:14:45]

argh, I've become dependent on having the linter in the upload checks.

+                      or {})
     if not compile_targets:
-      compile_targets = []
-      main_target = ANDROID_INSTRUMENTATION_TARGET_MAP.get(name)
-      if main_target:
-        compile_targets.append(main_target)
-      compile_targets.extend(suite_defaults.get('extra_compile_targets', []))
+      compile_targets = [suite_defaults['compile_target']]

[ghost stip (do not use), 2016/03/01 15:54:52]

this will raise an exception if the target isn't in the map. maybe that's what
we want?

[jbudorick, 2016/03/01 16:14:45]

That's exactly what I want. I don't think there's a good way for us to recover
if we can't figure out what to build.

+      compile_targets.extend(
+          suite_defaults.get('additional_compile_targets', []))
 
     super(AndroidInstrumentationTest, self).__init__(
         name,
         compile_targets,
         isolate_file_path or suite_defaults.get('isolate_file_path'))
     self._additional_apks = (
         additional_apks or suite_defaults.get('additional_apks'))
     self._annotation = annotation
     self._apk_under_test = (
         apk_under_test or suite_defaults.get('apk_under_test'))
@@ skipping 236 matching lines @@
   def run(self, api, suffix, test_filter=None):
     api.chromium_android.coverage_report(upload=False)
     api.chromium_android.get_changed_lines_for_revision()
     api.chromium_android.incremental_coverage_report()
 
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]