[arm] Allow immediate-index write barriers.

[arm] Allow immediate-index write barriers.

This is effectively a port of 4eff883b (r27731).

BUG=

Committed: https://crrev.com/c72b49bddcf1484bf3553ea702cf1764690a33df
Cr-Commit-Position: refs/heads/master@{#33994}

[jbramley, 2016-02-12 15:25:01]

jacob.bramley@arm.com changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[Benedikt Meurer, 2016-02-12 17:57:24]

LGTM with nits.

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
File src/compiler/arm/code-generator-arm.cc (right):

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
src/compiler/arm/code-generator-arm.cc:245: DCHECK(index_immediate_ == 0);
Nit: DCHECK_EQ(0, index_immediate_)

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
src/compiler/arm/code-generator-arm.cc:557: DCHECK(addressing_mode ==
kMode_Offset_RR);
Nit: DCHECK_EQ(kMode_Offset_RR, addressing_mode)

[jbramley, 2016-02-15 13:31:28]

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
File src/compiler/arm/code-generator-arm.cc (right):

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
src/compiler/arm/code-generator-arm.cc:245: DCHECK(index_immediate_ == 0);
On 2016/02/12 17:57:24, Benedikt Meurer wrote:
> Nit: DCHECK_EQ(0, index_immediate_)

Done.

https://codereview.chromium.org/1692253002/diff/1/src/compiler/arm/code-gener...
src/compiler/arm/code-generator-arm.cc:557: DCHECK(addressing_mode ==
kMode_Offset_RR);
On 2016/02/12 17:57:24, Benedikt Meurer wrote:
> Nit: DCHECK_EQ(kMode_Offset_RR, addressing_mode)

Done.

[jbramley, 2016-02-15 13:31:33]

The CQ bit was checked by jacob.bramley@arm.com

[jbramley, 2016-02-15 13:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1692253002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-02-15 13:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692253002/20001

[commit-bot: I haz the power, 2016-02-15 13:46:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-15 13:46:35]

Description was changed from

==========
[arm] Allow immediate-index write barriers.

This is effectively a port of 4eff883b (r27731).

BUG=
==========

to

==========
[arm] Allow immediate-index write barriers.

This is effectively a port of 4eff883b (r27731).

BUG=

Committed: https://crrev.com/c72b49bddcf1484bf3553ea702cf1764690a33df
Cr-Commit-Position: refs/heads/master@{#33994}
==========

[commit-bot: I haz the power, 2016-02-15 13:46:36]

Patchset 2 (id:??) landed as
https://crrev.com/c72b49bddcf1484bf3553ea702cf1764690a33df
Cr-Commit-Position: refs/heads/master@{#33994}