Allow transformers to exclude and include assets.

sdk/lib/_internal/pub/test/pubspec_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pubspec_test;
 
 import 'package:unittest/unittest.dart';
 
 import '../lib/src/pubspec.dart';
 import '../lib/src/source.dart';
@@ skipping 223 matching lines @@
           (pubspec) => pubspec.transformers,
           '"transformers" field must be a string or map');
     });
 
     test("throws if a transformer's configuration isn't a map", () {
       expectPubspecException('transformers: [{pkg: 12}]',
           (pubspec) => pubspec.transformers,
           '"transformers.pkg" field must be a map');
     });
 
-    test("throws if a transformer's configuration contains a top-level key "
-        "beginning with a dollar sign", () {
+    test("throws if a transformer's configuration contains an unknown "
+        "reserved key at the top level", () {
       expectPubspecException('''
 name: pkg
 transformers: [{pkg: {\$key: "value"}}]''',
           (pubspec) => pubspec.transformers,
-          '"transformers.pkg" field cannot contain reserved field "\$key"');
+          'Unknown reserved field "\$key"');

[nweiz, 2014/02/24 21:42:46]

This is a much worse error message than before. It's very valuable to include
the path to the key.

The errors below also don't contain the path.

[Bob Nystrom, 2014/02/26 01:09:41]

Done. The paths were always in the error message, the tests just didn't validate
it. Now they do.

     });
 
     test("doesn't throw if a transformer's configuration contains a "
         "non-top-level key beginning with a dollar sign", () {
       var pubspec = new Pubspec.parse('''
 name: pkg
 transformers:
 - pkg: {outer: {\$inner: value}}
 ''', sources);
 
       var pkg = pubspec.transformers[0].single;
       expect(pkg.configuration["outer"]["\$inner"], equals("value"));
     });
 
+    test("throws if the \$include value is not a string or list", () {
+      expectPubspecException('''
+name: pkg
+transformers:
+- pkg: {\$include: 123}''',
+          (pubspec) => pubspec.transformers,
+          '"\$include" field must be a string or list, but was "123"');
+    });
+
+    test("throws if the \$include list contains a non-string", () {
+      expectPubspecException('''
+name: pkg
+transformers:
+- pkg: {\$include: ["ok", 123, "alright", null]}''',
+        (pubspec) => pubspec.transformers,
+        '"\$include" list field may only contain strings, but contained '
+        '"123" and "null"');
+    });
+
+    test("throws if the \$exclude value is not a string or list", () {
+      expectPubspecException('''
+name: pkg
+transformers:
+- pkg: {\$exclude: 123}''',
+        (pubspec) => pubspec.transformers,
+        '"\$exclude" field must be a string or list, but was "123"');
+    });
+
+    test("throws if the \$exclude list contains a non-string", () {
+      expectPubspecException('''
+name: pkg
+transformers:
+- pkg: {\$exclude: ["ok", 123, "alright", null]}''',
+        (pubspec) => pubspec.transformers,
+        '"\$exclude" list field may only contain strings, but contained '
+        '"123" and "null"');
+    });
+
     test("throws if a transformer is not from a dependency", () {
       expectPubspecException('''
 name: pkg
 transformers: [foo]
 ''',
           (pubspec) => pubspec.transformers,
           '"transformers.foo" refers to a package that\'s not a dependency.');
     });
 
     test("allows a transformer from a normal dependency", () {
@@ skipping 77 matching lines @@
             (pubspec) => pubspec.environment);
       });
 
       test("throws if the sdk isn't a valid version constraint", () {
         expectPubspecException('environment: {sdk: "oopies"}',
             (pubspec) => pubspec.environment);
       });
     });
   });
 }