Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169223003: Fire canplaythrough after play and playing when autoplaying (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Fire canplaythrough after play and playing when autoplaying The new test case is copied (with style adjustments) from https://github.com/w3c/web-platform-tests/pull/636 Once it is imported under LayoutTests/w3c/web-platform-tests/ it should be removed from LayoutTests/media/W3C/. BUG=344531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167438

Patch Set 1 #

Total comments: 6

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
A LayoutTests/media/autoplay.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + LayoutTests/media/autoplay-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/video-capture-preview.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/video-capture-preview-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
philipj_slow
https://codereview.chromium.org/169223003/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/169223003/diff/1/Source/core/html/HTMLMediaElement.cpp#newcode1612 Source/core/html/HTMLMediaElement.cpp:1612: if (isPotentiallyPlaying) This should actually be m_paused, but I ...
6 years, 10 months ago (2014-02-18 16:50:19 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % nits https://codereview.chromium.org/169223003/diff/1/LayoutTests/media/autoplay.html File LayoutTests/media/autoplay.html (right): https://codereview.chromium.org/169223003/diff/1/LayoutTests/media/autoplay.html#newcode8 LayoutTests/media/autoplay.html:8: function autoplay_test(tagName, src) { nit: 4-space ...
6 years, 10 months ago (2014-02-18 18:30:36 UTC) #2
philipj_slow
https://codereview.chromium.org/169223003/diff/1/LayoutTests/media/autoplay.html File LayoutTests/media/autoplay.html (right): https://codereview.chromium.org/169223003/diff/1/LayoutTests/media/autoplay.html#newcode8 LayoutTests/media/autoplay.html:8: function autoplay_test(tagName, src) { On 2014/02/18 18:30:37, acolwell wrote: ...
6 years, 10 months ago (2014-02-19 03:10:04 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-19 03:23:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169223003/90001
6 years, 10 months ago (2014-02-19 03:23:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 06:18:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27775
6 years, 10 months ago (2014-02-19 06:18:48 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-19 07:28:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169223003/90001
6 years, 10 months ago (2014-02-19 07:28:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 10:00:00 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27813
6 years, 10 months ago (2014-02-19 10:00:00 UTC) #11
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-19 10:07:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169223003/90001
6 years, 10 months ago (2014-02-19 10:08:24 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 13:41:18 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27864
6 years, 10 months ago (2014-02-19 13:41:18 UTC) #15
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-19 15:00:40 UTC) #16
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 10 months ago (2014-02-19 17:26:12 UTC) #17
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-19 17:26:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169223003/90001
6 years, 10 months ago (2014-02-19 21:53:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169223003/90001
6 years, 10 months ago (2014-02-19 22:59:17 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 23:22:20 UTC) #21
Message was sent while issue was closed. 
Change committed as 167438

Powered by Google App Engine
This is Rietveld 408576698