Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1692223002: Make FunctionTester::Compile() private. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make FunctionTester::Compile() private. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/a02df7e1f61328421aa92b1325bdedae7b96e158 Cr-Commit-Position: refs/heads/master@{#33954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M test/cctest/compiler/function-tester.h View 2 chunks +12 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +17 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-02-12 14:42:46 UTC) #1
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-12 16:53:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692223002/1
4 years, 10 months ago (2016-02-12 16:59:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 17:28:56 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 17:29:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a02df7e1f61328421aa92b1325bdedae7b96e158
Cr-Commit-Position: refs/heads/master@{#33954}

Powered by Google App Engine
This is Rietveld 408576698