Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 16922002: Do not load deferred/disabled data uri images. (Closed)

Created:
6 years, 5 months ago by pdr.
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org, mnaganov (inactive)
Visibility:
Public.

Description

Do not load deferred/disabled data uri images. This patch fixes a bug where deferred data uri images were loaded. After this patch, if an image is deferred, determineRevalidationPolicy will reload the image which will both evict a previously cached image and stop the image load. BUG=249013 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152322

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
A LayoutTests/fast/loader/data-images-with-images-disabled.html View 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/fast/loader/data-images-with-images-disabled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.cpp View 2 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
pdr.
6 years, 5 months ago (2013-06-13 04:32:08 UTC) #1
abarth-chromium
LGTM Do we need to worry about any of the other checks in this list? ...
6 years, 5 months ago (2013-06-13 04:38:51 UTC) #2
pdr.
On 2013/06/13 04:38:51, abarth wrote: > LGTM > > Do we need to worry about ...
6 years, 5 months ago (2013-06-13 04:52:27 UTC) #3
pdr.
6 years, 5 months ago (2013-06-13 05:05:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r152322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698