Do not load deferred/disabled data uri images.

Do not load deferred/disabled data uri images.

This patch fixes a bug where deferred data uri images were loaded.
After this patch, if an image is deferred, determineRevalidationPolicy
will reload the image which will both evict a previously cached image
and stop the image load.

BUG=249013
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152322

[abarth-chromium, 2013-06-13 04:38:51]

LGTM

Do we need to worry about any of the other checks in this list?

https://codereview.chromium.org/16922002/diff/1/Source/core/loader/cache/Cach...
File Source/core/loader/cache/CachedResourceLoader.cpp (right):

https://codereview.chromium.org/16922002/diff/1/Source/core/loader/cache/Cach...
Source/core/loader/cache/CachedResourceLoader.cpp:717: if (type ==
CachedResource::ImageResource && request.url().protocolIsData())
Ah, interesting.

[pdr., 2013-06-13 04:52:27]

On 2013/06/13 04:38:51, abarth wrote:
> LGTM
> 
> Do we need to worry about any of the other checks in this list?

Because r152093 added the data uri check, for non-data-uri images, all that has
changed is the order of returning reload. Therefore, nothing should be worse, if
that's any consolation :)

Re-reading the list during this patch, I wonder if we should move "if
(!existingResource->canReuse(request)) return Reload;" above the data uri check?

[pdr., 2013-06-13 05:05:34]

Committed patchset #1 manually as r152322 (presubmit successful).