Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1692193002: [runtime] Remove obsolete %ObjectEquals runtime entry. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove obsolete %ObjectEquals runtime entry. There are only two uses of %_ObjectEquals left, which should actually use strict equality instead, so there's no need to keep this special logic at all. R=mvstanton@chromium.org Committed: https://crrev.com/c67262d4eaafc613809e38fd1e3f7cbe8ccf300f Cr-Commit-Position: refs/heads/master@{#33948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -230 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-12 13:25:07 UTC) #1
Benedikt Meurer
Hey Michael, Here's an easy one, removing more unused intrinsics. Please take a look. Thanks, ...
4 years, 10 months ago (2016-02-12 13:25:48 UTC) #2
mvstanton
lgtm
4 years, 10 months ago (2016-02-12 13:28:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692193002/1
4 years, 10 months ago (2016-02-12 13:34:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 14:07:49 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 14:08:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c67262d4eaafc613809e38fd1e3f7cbe8ccf300f
Cr-Commit-Position: refs/heads/master@{#33948}

Powered by Google App Engine
This is Rietveld 408576698