[wasm] Add support for a start function.

[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y

Committed: https://crrev.com/5c5c6e38e2e3cd98825eab027986280b4db006a5
Cr-Commit-Position: refs/heads/master@{#33978}

[bradnelson, 2016-02-12 17:29:55]

lgtm with suggestions

https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
File test/mjsunit/wasm/start-function.js (right):

https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
test/mjsunit/wasm/start-function.js:8: 
Maybe add a test that two start sections fail?

https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
test/mjsunit/wasm/start-function.js:58: assertFails([1, kAstI32, kAstI32],
[kExprGetLocal, 0]);
Maybe either comment the goal is to confirm functions >0 args are forbidden, or
maybe assert the particular exception string?

https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
test/mjsunit/wasm/start-function.js:139: print("we ranned at stert!");
This was totally done at 1am yeah? :-)

[titzer, 2016-02-12 17:46:01]

On 2016/02/12 17:29:55, bradnelson wrote:
> lgtm with suggestions
> 
>
https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
> File test/mjsunit/wasm/start-function.js (right):
> 
>
https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
> test/mjsunit/wasm/start-function.js:8: 
> Maybe add a test that two start sections fail?
> 

Good idea. And caught a bug.

>
https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
> test/mjsunit/wasm/start-function.js:58: assertFails([1, kAstI32, kAstI32],
> [kExprGetLocal, 0]);
> Maybe either comment the goal is to confirm functions >0 args are forbidden,
or
> maybe assert the particular exception string?
> 

Commented.

>
https://codereview.chromium.org/1692173002/diff/1/test/mjsunit/wasm/start-fun...
> test/mjsunit/wasm/start-function.js:139: print("we ranned at stert!");
> This was totally done at 1am yeah? :-)

1pm completely sane :-)

[titzer, 2016-02-12 17:46:09]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-12 17:46:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1692173002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-02-12 17:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692173002/40001

[dougc, 2016-02-12 20:15:10]

Might it be necessary to bump up the kMaxModuleSectionCode in order to have the
check for it appearing more than once working? E.g. 'static const int
kMaxModuleSectionCode = 7;' I assume this new section can not appear more than
once.

[titzer, 2016-02-15 08:38:17]

Description was changed from

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
==========

[titzer, 2016-02-15 08:38:26]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-15 08:38:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1692173002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-02-15 08:38:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692173002/60001

[commit-bot: I haz the power, 2016-02-15 08:40:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-15 08:40:40]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10948)

[titzer, 2016-02-15 08:42:46]

Description was changed from

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
==========

to

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y
==========

[titzer, 2016-02-15 08:42:51]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-02-15 08:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692173002/60001

[commit-bot: I haz the power, 2016-02-15 08:58:55]

Description was changed from

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y
==========

to

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y
==========

[commit-bot: I haz the power, 2016-02-15 08:58:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-15 08:59:24]

Description was changed from

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y
==========

to

==========
[wasm] Add support for a start function.

Add a section identifier for declaring a start function as an index into
the function table. (This could also be done as a decl flag on the
function, but don't feel strongly here, since we probably want to redo
this when adding an import/export section.)

The start function must accept no parameters. Its return value is
currently ignored.

R=binji@chromium.org,bradnelson@chromium.org
BUG=chromium:575167
LOG=Y

Committed: https://crrev.com/5c5c6e38e2e3cd98825eab027986280b4db006a5
Cr-Commit-Position: refs/heads/master@{#33978}
==========

[commit-bot: I haz the power, 2016-02-15 08:59:24]

Patchset 4 (id:??) landed as
https://crrev.com/5c5c6e38e2e3cd98825eab027986280b4db006a5
Cr-Commit-Position: refs/heads/master@{#33978}