Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1692153002: Revert of [CT] Use zips of SKPs to speed up "isolate tests" (Closed)

Created:
4 years, 10 months ago by rmistry1
Modified:
4 years, 10 months ago
Reviewers:
rmistry, M-A Ruel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [CT] Use zips of SKPs to speed up "isolate tests" (patchset #3 id:40001 of https://codereview.chromium.org/1691023002/ ) Reason for revert: The zipping and unzipping process seems to take longer than the isolate binary did for >100k files. Reverting this experiment. I am instead going to break up the "isolate tests" steps into multiple steps if >100k files. Original issue's description: > [CT] Use zips of SKPs to speed up "isolate tests". > > Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) > This change compresses the 1M SKPs into 100 zip files. > > BUG= TBR=maruel@chromium.org,rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/477367fece4f39630a312c0ad51b1fafc49fe93f Cr-Commit-Position: refs/heads/master@{#375164}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/ct_skps.isolate View 1 chunk +1 line, -1 line 0 comments Download
M content/test/ct/run_ct_skps.py View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmistry1
Created Revert of [CT] Use zips of SKPs to speed up "isolate tests"
4 years, 10 months ago (2016-02-12 12:03:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692153002/1
4 years, 10 months ago (2016-02-12 12:03:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 12:04:29 UTC) #4
M-A Ruel
On 2016/02/12 12:04:29, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) Ok, ...
4 years, 10 months ago (2016-02-12 14:22:26 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/477367fece4f39630a312c0ad51b1fafc49fe93f
Cr-Commit-Position: refs/heads/master@{#375164}

Powered by Google App Engine
This is Rietveld 408576698