Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1692103002: [MD settings] propagating no-label-float from settings-dropdown-menu (Closed)

Created:
4 years, 10 months ago by dschuyler
Modified:
4 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] propagating no-label-float from settings-dropdown-menu This CL allows for setting the no-label-float property on a settings-dropdown-menu. This CL also includes some uses of no-label-float in the Appearance settings. BUG=531786 Committed: https://crrev.com/d46ebd1a6ca0cc4bc7842882e03cadccfcb91253 Cr-Commit-Position: refs/heads/master@{#375225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 10 months ago (2016-02-12 01:58:38 UTC) #2
dpapad
lgtm
4 years, 10 months ago (2016-02-12 19:25:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692103002/1
4 years, 10 months ago (2016-02-12 19:29:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 19:44:10 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:44:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d46ebd1a6ca0cc4bc7842882e03cadccfcb91253
Cr-Commit-Position: refs/heads/master@{#375225}

Powered by Google App Engine
This is Rietveld 408576698