Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1692083002: Update CMake build to support gflags and gtest correctly (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
fbarchard1
CC:
magjed1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv.git@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Update CMake build to support gflags and gtest correctly The gflags library was missing from the CMake build and the gtest includes were not being set correctly. R=fbarchard@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/20343f45c612e485cd898aeaae2250df2d0b2d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M CMakeLists.txt View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
4 years, 10 months ago (2016-02-12 00:24:18 UTC) #2
fbarchard1
lgtm
4 years, 10 months ago (2016-02-12 23:41:16 UTC) #3
fbarchard1
4 years, 10 months ago (2016-02-12 23:43:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20343f45c612e485cd898aeaae2250df2d0b2d2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698