Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1692053002: Delete SkDecodingImageGenerator (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@noble
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -1745 lines) Patch
M gyp/images.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D include/images/SkDecodingImageGenerator.h View 1 chunk +0 lines, -119 lines 0 comments Download
D src/images/SkDecodingImageGenerator.cpp View 1 chunk +0 lines, -288 lines 0 comments Download
D tests/ImageDecodingTest.cpp View 1 chunk +0 lines, -732 lines 0 comments Download
D tests/JpegTest.cpp View 1 chunk +0 lines, -604 lines 0 comments Download
A tests/YUVTest.cpp View 1 chunk +121 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
msarett
I don't think anyone is using this (apart from test code). This will bring Skia's ...
4 years, 10 months ago (2016-02-11 21:45:16 UTC) #3
reed1
I always approve deleting code! lgtm
4 years, 10 months ago (2016-02-11 21:49:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692053002/1
4 years, 10 months ago (2016-02-11 21:51:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 22:17:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/829caa2f6b3f021197b27a041355e4410626ef3e

Powered by Google App Engine
This is Rietveld 408576698