Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1692013002: Change SkMatrix::fixedStepInX to return SkVector rather than SkFixed. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change SkMatrix::fixedStepInX to return SkVector (of SkScalar) rather than SkFixed. All users were immediately converting to SkScalar or SkFixed3232. This method is not used in Chromium, Android, or Google3. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692013002 Committed: https://skia.googlesource.com/skia/+/8e17556349132a46c02fbabcaf74b63f521528e0

Patch Set 1 #

Patch Set 2 : Split fixedStepInX into bool isFixedStepInX and SkVector fixedStepInX. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -46 lines) Patch
M include/core/SkMatrix.h View 1 1 chunk +8 lines, -3 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 2 chunks +12 lines, -24 lines 0 comments Download
M src/core/SkShader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692013002/1
4 years, 10 months ago (2016-02-11 21:12:10 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 21:40:41 UTC) #6
dogben
There are GM diffs, so if you think I should commit this, I'll need some ...
4 years, 10 months ago (2016-02-11 21:43:36 UTC) #8
reed1
I like this trend! Can we change the check into an assert inside the function, ...
4 years, 10 months ago (2016-02-11 21:48:00 UTC) #9
reed1
4 years, 10 months ago (2016-02-11 21:48:51 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692013002/20001
4 years, 10 months ago (2016-02-12 15:44:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 16:08:34 UTC) #16
dogben
What do you think of this? I needed to add isFixedStepInX. If you don't like ...
4 years, 10 months ago (2016-02-12 16:09:49 UTC) #17
reed1
lgtm
4 years, 10 months ago (2016-02-15 21:02:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692013002/20001
4 years, 10 months ago (2016-02-16 17:38:18 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:09:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8e17556349132a46c02fbabcaf74b63f521528e0

Powered by Google App Engine
This is Rietveld 408576698