[builtins] Remove almost all remaining uses of %_Arguments and %_ArgumentsLength.

[builtins] Remove almost all remaining uses of %_Arguments and %_ArgumentsLength.

There's only one last user of %_Arguments and %_ArgumentsLength left,
the rest was updated to either strict mode arguments object or to not
use arguments at all.

R=yangguo@chromium.org

Committed: https://crrev.com/0e79d8c71fc058e572d55d0748f637c647ce559d
Cr-Commit-Position: refs/heads/master@{#33935}

[Benedikt Meurer, 2016-02-12 09:23:38]

Hey Yang,

It's almost done (reason we need to deal with the left over one specially is
SunSpider). :-)
Please take a look.

Thanks,
Benedikt

[Yang, 2016-02-12 09:25:39]

LGTM, but I prefer a consistent use of SetFunctionLength over arguments where we
use arguments to appease function length requirement.

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js
File src/js/string.js (right):

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js#newcode120
src/js/string.js:120: if (arguments.length > 1) {
why not do the same thing as for StringIndexOf?

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js#newcode179
src/js/string.js:179: var formArg = arguments[0];
I also prefer SetFunctionLength for this as well.

[Benedikt Meurer, 2016-02-12 09:30:14]

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js
File src/js/string.js (right):

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js#newcode120
src/js/string.js:120: if (arguments.length > 1) {
On 2016/02/12 09:25:39, Yang wrote:
> why not do the same thing as for StringIndexOf?

Done.

https://codereview.chromium.org/1692003003/diff/1/src/js/string.js#newcode179
src/js/string.js:179: var formArg = arguments[0];
On 2016/02/12 09:25:39, Yang wrote:
> I also prefer SetFunctionLength for this as well.

Done.

[Benedikt Meurer, 2016-02-12 09:39:36]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-02-12 09:39:36]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1692003003/#ps2 (title:
"Address feedback.")

[commit-bot: I haz the power, 2016-02-12 09:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692003003/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692003003/2

[commit-bot: I haz the power, 2016-02-12 10:07:28]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2016-02-12 10:08:12]

Description was changed from

==========
[builtins] Remove almost all remaining uses of %_Arguments and
%_ArgumentsLength.

There's only one last user of %_Arguments and %_ArgumentsLength left,
the rest was updated to either strict mode arguments object or to not
use arguments at all.

R=yangguo@chromium.org
==========

to

==========
[builtins] Remove almost all remaining uses of %_Arguments and
%_ArgumentsLength.

There's only one last user of %_Arguments and %_ArgumentsLength left,
the rest was updated to either strict mode arguments object or to not
use arguments at all.

R=yangguo@chromium.org

Committed: https://crrev.com/0e79d8c71fc058e572d55d0748f637c647ce559d
Cr-Commit-Position: refs/heads/master@{#33935}
==========

[commit-bot: I haz the power, 2016-02-12 10:08:13]

Patchset 2 (id:??) landed as
https://crrev.com/0e79d8c71fc058e572d55d0748f637c647ce559d
Cr-Commit-Position: refs/heads/master@{#33935}